Skip to content

fix: Add container detection for other container runtimes #5835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DominicLavery
Copy link

Pull Request Submission Checklist

  • Follows CONTRIBUTING guidelines
  • Includes detailed description of changes
  • Contains risk assessment (Low | Medium | High)
  • Highlights breaking API changes (if applicable)
  • Links to automated tests covering new functionality
  • Includes manual testing instructions (if necessary)
  • Updates relevant GitBook documentation (PR link: ___)
  • Includes product update to be announced in the next stable release notes

What does this PR do?

This PR enables the container detection to work in container runtimes other than docker such as Podman and cri-o by checking for an additional file /run/.containerenv. This is a low risk change as it follows an established pattern in the codebase and has minimal changes.

Where should the reviewer start?

src/lib/is-docker.ts

How should this be manually tested?

Run the regression-tests tests inside a podman container

What's the product update that needs to be communicated to CLI users?

The CLI should no longer try and open a browser automatically when run in container environments other than dockers

Any background context you want to provide?

This relates to support request #159183 with CircleCI and should resolve issues running tests on the new container runtime.

@CLAassistant
Copy link

CLAassistant commented Apr 15, 2025

CLA assistant check
All committers have signed the CLA.

@DominicLavery DominicLavery force-pushed the add-alternative-runtimes-support branch from 265ef09 to 6af438d Compare April 15, 2025 11:19
@DominicLavery DominicLavery changed the title Add container detection for other container runtimes fix: Add container detection for other container runtimes Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants