PHP 8.2 | Fix deprecated embedded variables in text strings #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sirbrillig You may also want to consider moving CI to GH Actions for a more extensive CI check, same like we did for VariableAnalysis. |
PHP 8.2 will deprecate two of the four currently supported syntaxes for embedding variables in double quoted text string/heredocs.
This library contains one use of embedded variables using braces after the dollar sign (`"${foo}"`), which is one of the deprecated forms.
This commit fixes that.
Refs:
* https://wiki.php.net/rfc/deprecate_dollar_brace_string_interpolation
|
Rebased without changes to be ahead of |
jrfnl
force-pushed
the
php-8.2/fix-deprecated-embedded-var
branch
from
a45c884 to
da83c0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.2 will deprecate two of the four currently supported syntaxes for embedding variables in double quoted text string/heredocs.
This library contains one use of embedded variables using braces after the dollar sign (
"${foo}"), which is one of the deprecated forms.This commit fixes that.
Refs: