Skip to content

Add option to set a PostgreSQL schema #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2021
Merged

Add option to set a PostgreSQL schema #29

merged 2 commits into from
Jun 11, 2021

Conversation

jdormit
Copy link
Contributor

@jdormit jdormit commented Dec 28, 2020

Without this change, you can't use db-to-sqlite to copy tables that are in a Postgres schema other than the default one public.

@simonw
Copy link
Owner

simonw commented Dec 28, 2020

It's frustrating that this isn't part of the SQLAlchemy URL format! Thanks for the fix, looks good.

README.md Outdated

db-to-sqlite "postgresql://localhost/myblog" blog.db \
--all \
--postgres_schema my_schema
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny change: this should be --postgres-schema for consistency with the --index-fks and --no-index-fks options.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, updated!

@Dakuan
Copy link

Dakuan commented Apr 5, 2021

Any chance this can be merged?

Copy link

@shedworth shedworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me :)

@simonw
Copy link
Owner

simonw commented Jun 11, 2021

This looks great, thank you very much!

@simonw simonw mentioned this pull request Jun 11, 2021
@simonw simonw merged commit f078dc3 into simonw:main Jun 11, 2021
simonw added a commit that referenced this pull request Jun 11, 2021
simonw added a commit that referenced this pull request Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants