Skip to content

Account for state availability when fetching sync committees #7178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Ayushdubey86
Copy link

@Ayushdubey86 Ayushdubey86 commented Mar 20, 2025

Hello @michaelsproul , do check this pr out once free!

Issue Addressed

Which issue # does this PR address?
Issue -> #7115

Proposed Changes

This pr is a continuation of this pr
Please list or describe the changes introduced by this PR.

@michaelsproul
Copy link
Member

Please rebase on unstable as well and remove the unrelated changes from stable.

@chong-he chong-he added waiting-on-author The reviewer has suggested changes and awaits thier implementation. optimization Something to make Lighthouse run more efficiently. labels Mar 20, 2025
@Ayushdubey86
Copy link
Author

Please rebase on unstable as well and remove the unrelated changes from stable.

done

Copy link
Member

@macladson macladson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Ayushdubey86, the PR seems to have commits from other authors related to the mergify config. These changes are only on the stable branch and not present in unstable. Since we need you to target unstable, these changes will need to be removed. I would recommend doing an interactive rebase (git rebase -i unstable) and removing those specific commits. Thanks!

@Ayushdubey86 Ayushdubey86 changed the title Account for state availability when fetching sync committees #7115 Account for state availability when fetching sync committees May 10, 2025
@Ayushdubey86 Ayushdubey86 deleted the Account-for-state-availability-when-fetching-sync-committees-#7115 branch May 10, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimization Something to make Lighthouse run more efficiently. waiting-on-author The reviewer has suggested changes and awaits thier implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants