-
Notifications
You must be signed in to change notification settings - Fork 0
Sourcery refactored main branch #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
print("Error, could not open CSV File: " + csvFile) | ||
print(f"Error, could not open CSV File: {csvFile}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function parseCSV
refactored with the following changes:
- Use f-string instead of string concatenation [×6] (
use-fstring-for-concatenation
)
# print(f"averageChangePnL {averageChangePnL}") | ||
|
||
# Create the Analysis Text | ||
fileText = "" | ||
fileText += "Financial Analysis\n" | ||
fileText = "" + "Financial Analysis\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function writeResult
refactored with the following changes:
- Replace assignment and augmented assignment with single assignment (
merge-assign-and-aug-assign
) - Use
with
when opening file to ensure closure (ensure-file-closed
)
This removes the following comments ( why? ):
# print(f"averageChangePnL {averageChangePnL}")
# Create the Analysis Text
print("Error, could not open CSV File: " + csvFile) | ||
print(f"Error, could not open CSV File: {csvFile}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function parseCSV
refactored with the following changes:
- Use f-string instead of string concatenation [×6] (
use-fstring-for-concatenation
)
# Initialize Variables | ||
fileText = "" | ||
fileText += "Election Results\n" | ||
fileText = "" + "Election Results\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function writeResult
refactored with the following changes:
- Replace assignment and augmented assignment with single assignment (
merge-assign-and-aug-assign
) - Use
with
when opening file to ensure closure (ensure-file-closed
)
This removes the following comments ( why? ):
# Initialize Variables
Branch
main
refactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
main
branch, then run:Help us improve this pull request!