Skip to content

Add reference about micro/macrotask queues #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 7, 2021

Conversation

armanbilge
Copy link
Member

@armanbilge armanbilge commented Sep 7, 2021

Besides the small change in this PR, I've been pondering this statement.

If you're using ExecutionContext and not using this project, you likely have some serious bugs and/or performance issues waiting to be discovered.

Technically, doesn't this problem apply even when not using an EC? E.g. Scala.js code directly using Promises and setTimeout. Like, all SJS code should use this EC with Future.

@djspiewak djspiewak merged commit 254dadb into scala-js:main Sep 7, 2021
@djspiewak
Copy link
Collaborator

Technically, doesn't this problem apply even when not using an EC? E.g. Scala.js code directly using Promises and setTimeout. Like, all SJS code should use this EC with Future.

This is true, though in that case you're explicitly using those constructs, so presumably you're aware of the tradeoffs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants