-
-
Notifications
You must be signed in to change notification settings - Fork 29
Clean up paridecl #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4667322
to
6a6c113
Compare
@videlec What do you think of this pull request? |
That you should remove declarations in |
But why? If it's not broken, don't fix it! Especially if the fix involves a lot of manual work. |
|
Your proposal makes it less maintainable. It requires extra effort every time that we want to update
So what? The user only needs to care about
Which trouble are we having? |
Independently of possible future improvements, would you agree with merging this pull request now? We can still continue the discussion about |
right |
include
auto_paridecl.pxd
inparidecl.pxd
such that user code no longer needs to worry which file tocimport
.put the declarations for
pariinl.h
also inparidecl.pxd
(there was no reason to put these in a different file and Cython semi-deprecated.pxi
files so we should avoid them)declare some
enum
types ascdef enum