Skip to content

kitsune2_test_utils regression: using pseudo-canonical queries in typeck #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
compiler-errors opened this issue Apr 18, 2025 · 3 comments · Fixed by rust-lang/rust#140308
Assignees
Labels
E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added. from-crater A regression found via a crater run, not part of our test suite

Comments

@compiler-errors
Copy link
Member

compiler-errors commented Apr 18, 2025

https://crater-reports.s3.amazonaws.com/pr-133502-2/try%23da0a4799770027c4c578bf48cdb390acfde09023/reg/kitsune2_test_utils-0.1.3/log.txt

Weird repro but it gets the job done:

struct W<T>(*const T);

impl<T: Send> Clone for W<T> {
    fn clone(&self) -> Self { W(self.0) }
}

impl<T: Send> Copy for W<T> {}

fn main() {
    let coro = async {};
    let x = W(&raw const coro);
    let c = || {
        let x = x;
    };
}

Due to the fact that we strip opaques and generators out of the typing env when checking is_copy_raw, which is done by the expr use visitor.

@lcnr lcnr moved this from unknown to todo in -Znext-solver=globally Apr 19, 2025
@lcnr lcnr added the from-crater A regression found via a crater run, not part of our test suite label Apr 19, 2025
@lcnr lcnr changed the title kitsune2_test_utils regression kitsune2_test_utils regression: using pseudo-canonical in typeck Apr 19, 2025
@lcnr lcnr changed the title kitsune2_test_utils regression: using pseudo-canonical in typeck kitsune2_test_utils regression: using pseudo-canonical queries in typeck Apr 19, 2025
@compiler-errors compiler-errors self-assigned this Apr 20, 2025
@compiler-errors
Copy link
Member Author

Should be fixed by tweaks to the stall obligations PR.

@lcnr lcnr moved this from todo to in progress in -Znext-solver=globally Apr 20, 2025
@lcnr lcnr moved this from in progress to todo in -Znext-solver=globally Apr 20, 2025
@lcnr lcnr moved this from todo to done in -Znext-solver=globally Apr 24, 2025
@lcnr lcnr closed this as completed by moving to done in -Znext-solver=globally Apr 24, 2025
@lcnr
Copy link
Contributor

lcnr commented Apr 24, 2025

fixed by rust-lang/rust#138845

@lcnr
Copy link
Contributor

lcnr commented Apr 24, 2025

opening because I think we didn't add a test for this

@lcnr lcnr reopened this Apr 24, 2025
@lcnr lcnr added the E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added. label Apr 24, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Apr 25, 2025
stall generator witness obligations: add regression test

fixes rust-lang/trait-system-refactor-initiative#180

r? `@compiler-errors`
jhpratt added a commit to jhpratt/rust that referenced this issue Apr 26, 2025
stall generator witness obligations: add regression test

fixes rust-lang/trait-system-refactor-initiative#180

r? ``@compiler-errors``
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Apr 26, 2025
Rollup merge of rust-lang#140308 - lcnr:add-ui-test, r=compiler-errors

stall generator witness obligations: add regression test

fixes rust-lang/trait-system-refactor-initiative#180

r? ```@compiler-errors```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added. from-crater A regression found via a crater run, not part of our test suite
Projects
Development

Successfully merging a pull request may close this issue.

2 participants