Skip to content

Update crossbeam and release 0.3.2 #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 10, 2022

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Jan 10, 2022

This cherry-picks two updates from rayon-rs/rayon:

  • c7d963a Use crossbeam_deque::Injector instead of crossbeam_queue::SegQueue
  • e81835c Update crossbeam dependencies (requires Rust 1.36)

cc rust-lang/rust#92677

cuviper and others added 3 commits January 10, 2022 10:30
`Injector` and `SegQueue` are _almost_ identical, down to the very same
comments in their implementations. One difference is that `Injector`
allocates its first block as soon as it's created, but `SegQueue` waits
until its first `push`, which complicates it to allow being `null`.
`Injector` also has methods to steal batches into a deque `Worker`,
which might be useful to us.

At the very least, this lets us trim a dependency.
@cuviper cuviper merged commit 9fcf0ff into rust-lang:rustc Jan 10, 2022
@nagisa
Copy link
Member

nagisa commented Jan 10, 2022

Is there a reason why we don't merge in upstrea rayon as a whole, as opposed to cherry picking specific commits?

@cuviper
Copy link
Member Author

cuviper commented Jan 10, 2022

Just the amount of work that I don't have time to deal with. There are significant changes in the core scheduler.

@cuviper cuviper deleted the rustc-crossbeam branch January 10, 2022 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants