Skip to content

Add nalgebra-0.33.0-new-solver benchmark #2125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 16, 2025

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented May 16, 2025

This PR adds a copy of the nalgebra benchmark that uses the new trait solver. The expectation is that this will be a temporary-ish benchmark that will be removed once the new trait solver is used by default.

@Kobzol Kobzol requested a review from nnethercote May 16, 2025 10:11
Copy link
Member

@lqd lqd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't really need to add it to the compile-benchmarks readme benchmark list, right?

@Kobzol
Copy link
Contributor Author

Kobzol commented May 16, 2025

We don't really need to add it to the compile-benchmarks readme benchmark list, right?

I don't think so, but we'll need to add it to REUSE, thanks for reminding me!

@Kobzol Kobzol merged commit 03951e8 into rust-lang:master May 16, 2025
11 checks passed
@Kobzol Kobzol deleted the nalgebra-0.33.0-new-solver branch May 16, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants