Skip to content

Minor updates to stage docs. #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 3, 2020
Merged

Minor updates to stage docs. #781

merged 2 commits into from
Jul 3, 2020

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Jul 3, 2020 •
edited by JohnTitor
Loading

The libtest and libstd steps were merged a long time ago, so update the image for that.

Also, try to clarify some differences between stage1/2.

Fixes #431

@JohnTitor
Copy link
Member

JohnTitor commented Jul 3, 2020 •
edited
Loading

The change itself looks good to me. #434 updated the wording but it didn't do the diagram. As a bonus-point, it'd be great if the table on the bootstrapping chapter mentions libtest as well as libstd. Then I think this should close #431.

@ehuss
Copy link
Contributor Author

ehuss commented Jul 3, 2020

Ok, I added libtest to the table. (Also fixed the ? about libstd in stage2.)

JohnTitor
JohnTitor approved these changes Jul 3, 2020
View reviewed changes
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@JohnTitor JohnTitor merged commit 30518e3 into rust-lang:master Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

libtest build step has been merged with that of libstd
2 participants
@ehuss @JohnTitor