Skip to content

doc: Iterator::partition use partial type hints #92509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2022
Merged

doc: Iterator::partition use partial type hints #92509

merged 1 commit into from
Mar 6, 2022

Conversation

Gentoli
Copy link
Contributor

@Gentoli Gentoli commented Jan 3, 2022

Switch to partial type hints to indicate only the collection type is needed.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joshtriplett (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 3, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Gentoli
Copy link
Contributor Author

Gentoli commented Jan 3, 2022 

let a: [usize: 1] = [1];
a.into_iter()

a.into_iter() is ambiguous with (&[usize: 1]).into_iter() and ([usize: 1]).into_iter(), switched to Vec

@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 23, 2022
camelid
camelid reviewed Mar 3, 2022
View reviewed changes
@camelid camelid added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools T-libs Relevant to the library team, which will review and decide on the PR/issue. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 3, 2022
@Gentoli Gentoli requested a review from camelid March 6, 2022 00:42
camelid
camelid approved these changes Mar 6, 2022
View reviewed changes
Copy link
Member

@camelid camelid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@camelid
Copy link
Member

camelid commented Mar 6, 2022

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Mar 6, 2022

📌 Commit 62a6594 has been approved by camelid

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 6, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 6, 2022
@matthiaskrgr
Rollup merge of rust-lang#92509 - Gentoli:partition-ex, r=camelid
5f2ef3c 
doc: `Iterator::partition` use partial type hints

Switch to partial type hints to indicate only the collection type is needed.
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 6, 2022
Closed
@fee1-dead fee1-dead mentioned this pull request Mar 6, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 6, 2022
@bors
Auto merge of rust-lang#94668 - fee1-dead:rollup-8e92bht, r=fee1-dead
d53e195 
Rollup of 3 pull requests

Successful merges:

 - rust-lang#92509 (doc: `Iterator::partition` use partial type hints)
 - rust-lang#94621 (rustbuild: support RelWithDebInfo for lld)
 - rust-lang#94649 (Unix path::absolute: Fix leading "." component)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d85e4b1 into rust-lang:master Mar 6, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 6, 2022
@Gentoli Gentoli deleted the partition-ex branch March 7, 2022 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camelid camelid camelid approved these changes

Assignees

@joshtriplett joshtriplett

Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.61.0
Development

Successfully merging this pull request may close these issues.
8 participants
@Gentoli @rust-highfive @rust-log-analyzer @camelid @bors @joshtriplett @JohnCSimon @rustbot