-
Notifications
You must be signed in to change notification settings - Fork 13.3k
initialize Predicate and Ty interners with higher capacity #90743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(rust-highfive has picked a reviewer for you, use r? to override) |
@bors try @rust-timer queue Expected outcome: faster check builds, possible regression in max-rss by a fixed amount per rustc invocation (not code-dependent) |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 98a2032 with merge 9869d54de4acbf66ee1cc59bfcc173c0be8993c3... |
☀️ Try build successful - checks-actions |
Queued 9869d54de4acbf66ee1cc59bfcc173c0be8993c3 with parent d608229, future comparison URL. |
Finished benchmarking commit (9869d54de4acbf66ee1cc59bfcc173c0be8993c3): comparison url. Summary: This change led to moderate relevant improvements 🎉 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. @bors rollup=never |
max-rss impact is bigger than expected. page faults too. |
bfef8fd
to
1cbfe5d
Compare
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 1cbfe5d7020401d9dfa6c17e32124748d8d951a6 with merge e205bcd83c263da56a7592bb671f1327d1369bed... |
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
…e a few of them per process
1cbfe5d
to
1c294f1
Compare
This comment has been minimized.
This comment has been minimized.
@bors try |
⌛ Trying commit 1c294f1 with merge 6c099d0e977ff048ef53e45db7b43c1807268134... |
☀️ Try build successful - checks-actions |
Queued 6c099d0e977ff048ef53e45db7b43c1807268134 with parent b416e38, future comparison URL. |
Finished benchmarking commit (6c099d0e977ff048ef53e45db7b43c1807268134): comparison url. Summary: This change led to very large relevant mixed results 🤷 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never |
No description provided.