Skip to content

Add :target selector for highlight on any heading #86149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jsha
Copy link
Contributor

@jsha jsha commented Jun 8, 2021

This gives section headings the same highlight-on-click treatment that
method names get.

Fixes #86012

r? @GuillaumeGomez

This gives section headings the same highlight-on-click treatment that
method names get.
@rust-highfive
Copy link
Contributor

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez

Some changes occurred in HTML/CSS themes.

cc @GuillaumeGomez

A change occurred in the Ayu theme.

cc @Cldfire

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 8, 2021
@GuillaumeGomez
Copy link
Member

Looks good to me, thanks! Please add a GUI test. ;)

@bors
Copy link
Collaborator

bors commented Jun 17, 2021

☔ The latest upstream changes (presumably #86399) made this pull request unmergeable. Please resolve the merge conflicts.

@JohnCSimon JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 6, 2021
@JohnCSimon
Copy link
Member

Ping from triage:
@jsha - can you please address the merge conflicts and reviewer comments?

@jsha
Copy link
Contributor Author

jsha commented Jul 6, 2021

Thanks for the ping. I'm going to close this for now and work on it some more when I come back from vacation.

@jsha jsha closed this Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rustdoc: highlight all anchored headings on click
5 participants