Skip to content

Document Hasher spec decision from #42951 #83390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2021
Merged

Document Hasher spec decision from #42951 #83390

merged 1 commit into from
Apr 26, 2021

Conversation

clarfonthey
Copy link
Contributor

@clarfonthey clarfonthey commented Mar 22, 2021 •
edited
Loading

Since that ticket was closed without the decision actually being documented.

Fixes #42951.

@rust-highfive
Copy link
Contributor

r? @joshtriplett

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 22, 2021
@clarfonthey clarfonthey mentioned this pull request Mar 22, 2021
Closed
Amanieu
Amanieu reviewed Mar 22, 2021
View reviewed changes
Copy link
Member

@Amanieu Amanieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add a comment on Hash::hash_slice which says that hash_slice is not necessarily equivalent to multiple calls to hash.

@clarfonthey
Copy link
Contributor Author

clarfonthey commented Mar 22, 2021 •
edited
Loading

Could you also add a comment on Hash::hash_slice which says that hash_slice is not necessarily equivalent to multiple calls to hash.

Since this doesn't really fit in the Hasher docs, I mentioned this on the method directly, including the VecDeque example. If anyone has any suggestions on how to better word this, feel free; I decided that more detail was better than less.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@crlf0710 crlf0710 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 9, 2021
@clarfonthey
Copy link
Contributor Author

Realised that I accidentally left this hanging and applied the suggested changes + rebased. Appears to be passing tests too but I'll wait for CI on that.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jyn514 jyn514 assigned Amanieu and unassigned joshtriplett Apr 19, 2021
@Amanieu
Copy link
Member

Amanieu commented Apr 20, 2021

You need to point directly to the html file for doc links to std: ../../std/collections/struct.VecDeque.html

@Amanieu
Copy link
Member

Amanieu commented Apr 26, 2021

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 26, 2021

📌 Commit 920de7d has been approved by Amanieu

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 26, 2021
@bors
Copy link
Collaborator

bors commented Apr 26, 2021

⌛ Testing commit 920de7d with merge 7bd62a8...

@bors
Copy link
Collaborator

bors commented Apr 26, 2021

☀️ Test successful - checks-actions
Approved by: Amanieu
Pushing 7bd62a8 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 26, 2021
@bors bors merged commit 7bd62a8 into rust-lang:master Apr 26, 2021
@rustbot rustbot added this to the 1.53.0 milestone Apr 26, 2021
@clarfonthey clarfonthey deleted the hasher_docs branch May 2, 2021 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amanieu Amanieu Amanieu left review comments

@jyn514 jyn514 jyn514 left review comments

Assignees

@Amanieu Amanieu

Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.53.0
Development

Successfully merging this pull request may close these issues.

Spec request. Hasher: is write_u32 eqivalent to 4 calls of write_u8?
9 participants
@clarfonthey @rust-highfive @rust-log-analyzer @Amanieu @bors @jyn514 @joshtriplett @crlf0710 @rustbot