Skip to content

enable atomic_min/max tests in Miri #82704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 3, 2021
Merged

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Mar 2, 2021

Thanks to @henryboisdequin and @GregBowyer, Miri now supports these intrinsics. :)
Also includes the necessary Miri update.

@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Contributor

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 2, 2021
@RalfJung
Copy link
Member Author

RalfJung commented Mar 2, 2021

r? @oli-obk

@oli-obk
Copy link
Contributor

oli-obk commented Mar 3, 2021

@bors r+ p=1

@bors
Copy link
Collaborator

bors commented Mar 3, 2021

📌 Commit be958e1 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 3, 2021
@bors
Copy link
Collaborator

bors commented Mar 3, 2021

⌛ Testing commit be958e1 with merge 939b143...

@bors
Copy link
Collaborator

bors commented Mar 3, 2021

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 939b143 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 3, 2021
@bors bors merged commit 939b143 into rust-lang:master Mar 3, 2021
@rustbot rustbot added this to the 1.52.0 milestone Mar 3, 2021
@RalfJung RalfJung deleted the miri-atomic-minmax branch March 3, 2021 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants