Skip to content

Test default values for const parameters. #78960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 12, 2020
Merged

Test default values for const parameters. #78960

merged 2 commits into from
Nov 12, 2020

Conversation

eopb
Copy link
Contributor

@eopb eopb commented Nov 11, 2020

The last topic on #78433

I originally intended to place these tests in a single file, however, due to them being parser errors that are fatal, they must be in separate files to be detected.

Thanks, @lcnr for mentoring me on this PR.

r? @lcnr

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 11, 2020
@lcnr lcnr added F-const_generics `#![feature(const_generics)]` F-min_const_generics labels Nov 12, 2020
@lcnr
Copy link
Contributor

lcnr commented Nov 12, 2020

thanks

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 12, 2020

📌 Commit 1d3f9d0 has been approved by lcnr

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 12, 2020
This was referenced Nov 12, 2020
Closed
Merged
@bors bors merged commit a2e9e3b into rust-lang:master Nov 12, 2020
@rustbot rustbot added this to the 1.49.0 milestone Nov 12, 2020
@eopb eopb deleted the const-gen-test-default-error branch November 12, 2020 15:50
@alex alex mentioned this pull request Nov 13, 2020
Closed
8 tasks
@lcnr lcnr mentioned this pull request Nov 17, 2020
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lcnr lcnr

Labels
F-const_generics `#![feature(const_generics)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.49.0
Development

Successfully merging this pull request may close these issues.
5 participants
@eopb @lcnr @bors @rust-highfive @rustbot