-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Clean up E0752 explanation #75482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Clean up E0752 explanation #75482
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,19 @@ | ||
`fn main()` or the specified start function is not allowed to be | ||
async. You might be seeing this error because your async runtime | ||
library is not set up correctly. | ||
The entry point of the program was marked as `async`. | ||
|
||
Erroneous code example: | ||
|
||
```compile_fail,E0752 | ||
async fn main() -> Result<i32, ()> { | ||
Ok(1) | ||
async fn main() -> Result<(), ()> { // error! | ||
Ok(()) | ||
} | ||
``` | ||
|
||
`fn main()` or the specified start function is not allowed to be `async`. Not | ||
having a correct async runtime library setup may cause this error. To fix it, | ||
declare the entry point without `async`: | ||
|
||
``` | ||
fn main() -> Result<(), ()> { // ok! | ||
Ok(()) | ||
} | ||
``` | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should put up 3rd party suggestions in case a beginner stumbled up upon this, for example
#[tokio::runtime]
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We mention it, but I'm not sure it's a good idea to bring a specific library into a "general" example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where did we mentioned it? I don't quite like bringing a specific library here too but I believe beginners might not understand what is an async runtime, I first heard of the concept async runtime when I use rust so I do think we should point them somewhere. I don't have a good idea how but that is my suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think at this point, the error itself is clear enough. Imagine having an error with
smol
and seeing this explanation talk abouttokio
, it would be more confusing than helpful for newcomers I think.