-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Link to PhantomData in NonNull documentation #59427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
Should we be using intra-doc links here? |
I thought it was fine because it was already linking to |
Sure, this will work but I'm not sure if we're trying to incrementally migrate to intra doc links. Thinking on this some more though no reason this can't land in the meantime: @bors r+ rollup |
📌 Commit fd42918 has been approved by |
If the intra-doc links work there, then we can start incrementally migrating them. There have been several situations in libcore where an intra-doc link didn't work when re-exported into libstd, though, so there are some places where it doesn't work. It should be fine to try here, though - if i remember right, |
…-Simulacrum Link to PhantomData in NonNull documentation
Rollup of 7 pull requests Successful merges: - #59004 ([rustdoc] Improve "in parameters" search and search more generally) - #59026 (Fix moving text in search tabs headers) - #59197 (Exclude old book redirect stubs from search engines) - #59330 (Improve the documentation for std::convert (From, Into, AsRef and AsMut)) - #59424 (Fix code block display in portability element in dark theme) - #59427 (Link to PhantomData in NonNull documentation) - #59432 (Improve some compiletest documentation) Failed merges: r? @ghost
Rollup of 7 pull requests Successful merges: - #59004 ([rustdoc] Improve "in parameters" search and search more generally) - #59026 (Fix moving text in search tabs headers) - #59197 (Exclude old book redirect stubs from search engines) - #59330 (Improve the documentation for std::convert (From, Into, AsRef and AsMut)) - #59424 (Fix code block display in portability element in dark theme) - #59427 (Link to PhantomData in NonNull documentation) - #59432 (Improve some compiletest documentation) Failed merges: r? @ghost
No description provided.