Skip to content

Link to PhantomData in NonNull documentation #59427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2019

Conversation

czipperz
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 26, 2019
@Mark-Simulacrum
Copy link
Member

r? @QuietMisdreavus

Should we be using intra-doc links here?

@czipperz
Copy link
Contributor Author

I thought it was fine because it was already linking to UnsafeCell

@Mark-Simulacrum
Copy link
Member

Sure, this will work but I'm not sure if we're trying to incrementally migrate to intra doc links.

Thinking on this some more though no reason this can't land in the meantime: @bors r+ rollup

@bors
Copy link
Collaborator

bors commented Mar 26, 2019

📌 Commit fd42918 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 26, 2019
@QuietMisdreavus
Copy link
Member

If the intra-doc links work there, then we can start incrementally migrating them. There have been several situations in libcore where an intra-doc link didn't work when re-exported into libstd, though, so there are some places where it doesn't work. It should be fine to try here, though - if i remember right, core::ptr is re-exported wholesale, so it should be doable.

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Mar 26, 2019
…-Simulacrum

Link to PhantomData in NonNull documentation
bors added a commit that referenced this pull request Mar 26, 2019
Rollup of 7 pull requests

Successful merges:

 - #59004 ([rustdoc] Improve "in parameters" search and search more generally)
 - #59026 (Fix moving text in search tabs headers)
 - #59197 (Exclude old book redirect stubs from search engines)
 - #59330 (Improve the documentation for std::convert (From, Into, AsRef and AsMut))
 - #59424 (Fix code block display in portability element in dark theme)
 - #59427 (Link to PhantomData in NonNull documentation)
 - #59432 (Improve some compiletest documentation)

Failed merges:

r? @ghost
bors added a commit that referenced this pull request Mar 27, 2019
Rollup of 7 pull requests

Successful merges:

 - #59004 ([rustdoc] Improve "in parameters" search and search more generally)
 - #59026 (Fix moving text in search tabs headers)
 - #59197 (Exclude old book redirect stubs from search engines)
 - #59330 (Improve the documentation for std::convert (From, Into, AsRef and AsMut))
 - #59424 (Fix code block display in portability element in dark theme)
 - #59427 (Link to PhantomData in NonNull documentation)
 - #59432 (Improve some compiletest documentation)

Failed merges:

r? @ghost
@bors bors merged commit fd42918 into rust-lang:master Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants