Skip to content

slightly optimize compiletest test collection #57394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2019

Conversation

euclio
Copy link
Contributor

@euclio euclio commented Jan 7, 2019

Save quite a few syscalls and avoiding pushing in a loop.

@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 7, 2019
Save quite a few syscalls and avoiding pushing in a loop.
@euclio euclio force-pushed the compiletest-optimization branch from 7410471 to 2a9ad77 Compare January 7, 2019 04:23
@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 7, 2019

📌 Commit 2a9ad77 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 7, 2019
@bors
Copy link
Collaborator

bors commented Jan 7, 2019

⌛ Testing commit 2a9ad77 with merge 0194bed...

bors added a commit that referenced this pull request Jan 7, 2019
…crum

slightly optimize compiletest test collection

Save quite a few syscalls and avoiding pushing in a loop.
@bors
Copy link
Collaborator

bors commented Jan 7, 2019

☀️ Test successful - status-appveyor, status-travis
Approved by: Mark-Simulacrum
Pushing 0194bed to master...

@bors bors merged commit 2a9ad77 into rust-lang:master Jan 7, 2019
@euclio euclio deleted the compiletest-optimization branch January 7, 2019 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants