Obsolete message for capture clauses. #5102
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we're going to check the obsolete syntax here then I think we should do it for both |
|
Superseded by #5109 |
|
@Sethpink Sorry about that. If you do want to add the obsolete syntax error, I still think it's a good idea. |
|
Oops, sorry! Didn't see this one when I made mine. |
|
FWIW I do agree with brson that an obsolete syntax error would be nice, I just had no idea how to make that happen. :) |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 31, 2023
new lint: `redundant_locals` This lint checks for code like the following: ```rs let x = 1; let x = x; ``` It checks (afaik) all cases where a binding is shadowed by its own value in the same block, including function parameters. This has no effect and is almost certainly accidental, so it's in the `correctness` category like `self_assignment`. This also lays the groundwork for a more generalized version of rust-lang#5102. changelog: new lint: [`redundant_local`]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4965.
This will only detect obsolete capture clause using 'copy'. It seems the move keyword has been completely removed from the parser. Is this alright?