core: Rename to_mut and from_mut to cast_to_mut and cast_from_mut #4596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catamorphism
added a commit
that referenced
this pull request
Jan 23, 2013
core: Rename to_mut and from_mut to cast_to_mut and cast_from_mut
|
Thanks for the patch! In the future, please run |
|
I thought I patched all the tests, I did run make check right before sending the pull request. Sorry if I missed some. Thanks! |
bors
pushed a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 24, 2020
This is based almost entirely on the code available in the previous PR rust-lang#4596.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 24, 2020
New lint: Recommend using `ptr::eq` when possible This is based almost entirely on the code available in the previous PR rust-lang#4596. I merely updated the code to make it compile. Fixes rust-lang#3661. - [ ] I'm not sure about the lint name, but it was the one used in the original PR. - [X] Added passing UI tests (including committed `.stderr` file) - [X] `cargo test` passes locally - [X] Executed `cargo dev update_lints` - [X] Added lint documentation - [X] Run `cargo dev fmt` --- changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution to issue #3355 asking for the renaming of vec::to_mut/from_mut to cast_to_mut/cast_from_mut