Skip to content

Fix some typos #43794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 12, 2017
Merged

Fix some typos #43794

merged 2 commits into from
Aug 12, 2017

Conversation

Eijebong
Copy link
Contributor

I wrote a really naive script and found those typos in the documentation.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

Copy link
Contributor

@chordowl chordowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are quite amazing! ❤️

@@ -336,7 +336,7 @@ pub fn algorithm_m<T: RawFloat>(f: &Big, e: i16) -> T {
round_by_remainder(v, rem, q, z)
}

/// Skip over most AlgorithmM iterations by checking the bit length.
/// Skip over most Algorithm M iterations by checking the bit length.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be "algorithm", not "Algorithm M"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is another Algorithm M in the file, I assumed it was a name for an algorithm that was implemented in the file...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after we sort this out

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I change both to algorithm then ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, I just looked it up, it's documenting a function called algorithm_m

Copy link
Contributor

@chordowl chordowl Aug 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, my bad! Sorry!

@GuillaumeGomez
Copy link
Member

@bors: r=lukaramu,steveklanik,imperio rollup

@bors
Copy link
Collaborator

bors commented Aug 11, 2017

📌 Commit ea5be96 has been approved by lukaramu,steveklanik,imperio

MaloJaffre added a commit to MaloJaffre/rust that referenced this pull request Aug 11, 2017
…eklanik,imperio

Fix some typos

I wrote a really naive script and found those typos in the documentation.
@shepmaster shepmaster added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 11, 2017
@Eijebong Eijebong mentioned this pull request Aug 11, 2017
@Manishearth
Copy link
Member

@bors are you still there?

@bors
Copy link
Collaborator

bors commented Aug 11, 2017

🍰 Target acquired

@bors
Copy link
Collaborator

bors commented Aug 12, 2017

⌛ Testing commit ea5be96 with merge bffc973...

bors added a commit that referenced this pull request Aug 12, 2017
…erio

Fix some typos

I wrote a really naive script and found those typos in the documentation.
@bors
Copy link
Collaborator

bors commented Aug 12, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: lukaramu,steveklanik,imperio
Pushing bffc973 to master...

@bors bors merged commit ea5be96 into rust-lang:master Aug 12, 2017
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 13, 2017
Fix some typos

Follow up of rust-lang#43794

If refined my script a little bit and found some more.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants