-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Fix some typos #43794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some typos #43794
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are quite amazing! ❤️
@@ -336,7 +336,7 @@ pub fn algorithm_m<T: RawFloat>(f: &Big, e: i16) -> T { | |||
round_by_remainder(v, rem, q, z) | |||
} | |||
|
|||
/// Skip over most AlgorithmM iterations by checking the bit length. | |||
/// Skip over most Algorithm M iterations by checking the bit length. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be "algorithm", not "Algorithm M"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is another Algorithm M
in the file, I assumed it was a name for an algorithm that was implemented in the file...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me after we sort this out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I change both to algorithm
then ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nah, I just looked it up, it's documenting a function called algorithm_m
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, my bad! Sorry!
@bors: r=lukaramu,steveklanik,imperio rollup |
📌 Commit ea5be96 has been approved by |
…eklanik,imperio Fix some typos I wrote a really naive script and found those typos in the documentation.
@bors are you still there? |
…erio Fix some typos I wrote a really naive script and found those typos in the documentation.
☀️ Test successful - status-appveyor, status-travis |
Fix some typos Follow up of rust-lang#43794 If refined my script a little bit and found some more.
I wrote a really naive script and found those typos in the documentation.