Skip to content

rustdoc: shrink headings in non-top-level docblocks #43602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

QuietMisdreavus
Copy link
Member

Headings in per-method docs are often bigger than the function names/signatures themselves, so this tones those down to accentuate the methods.

screenshot of this change on Vec::swap_remove

Fixes #17193

@rust-highfive
Copy link
Contributor

Some changes occurred in HTML/CSS.

cc @GuillaumeGomez

@rust-highfive
Copy link
Contributor

r? @frewsxcv

(rust_highfive has picked a reviewer for you, use r? to override)

@QuietMisdreavus
Copy link
Member Author

To see this rendered on std, i have a version on my server - https://tonberry.quietmisdreavus.net/std-17193/std/index.html

@QuietMisdreavus QuietMisdreavus force-pushed the fantastic-shrinking-headings branch from cab2db6 to 5c4c2d9 Compare August 2, 2017 02:09
@GuillaumeGomez
Copy link
Member

I already approved this PR so let's merge it. Thanks!

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 2, 2017

📌 Commit 5c4c2d9 has been approved by GuillaumeGomez

@bors
Copy link
Collaborator

bors commented Aug 2, 2017

⌛ Testing commit 5c4c2d9 with merge 5c385be...

bors added a commit that referenced this pull request Aug 2, 2017
…r=GuillaumeGomez

rustdoc: shrink headings in non-top-level docblocks

Headings in per-method docs are often bigger than the function names/signatures themselves, so this tones those down to accentuate the methods.

![screenshot of this change on Vec::swap_remove](https://user-images.githubusercontent.com/5217170/28849380-6116a830-76dc-11e7-8ce2-04433d09463a.png)

Fixes #17193
@bors
Copy link
Collaborator

bors commented Aug 2, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: GuillaumeGomez
Pushing 5c385be to master...

@bors bors merged commit 5c4c2d9 into rust-lang:master Aug 2, 2017
@QuietMisdreavus QuietMisdreavus deleted the fantastic-shrinking-headings branch August 16, 2017 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants