Remove redundant assertion near is_char_boundary #38144
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
clarfonthey
force-pushed
the
redundant
branch
from
4310a75 to
4dd590a
Compare
|
@bors: r+ Thanks! |
|
📌 Commit 4dd590a has been approved by |
| @@ -1129,8 +1129,6 @@ impl String { | |||
| #[inline] | |||
| #[stable(feature = "rust1", since = "1.0.0")] | |||
| pub fn insert(&mut self, idx: usize, ch: char) { | |||
| let len = self.len(); | |||
| assert!(idx <= len); | |||
There was a problem hiding this comment.
It's redundant but it also affects the panic the users sees. The one below is the same, the last one is truly redundant.
There was a problem hiding this comment.
My personal opinion is that in this case, if we wanted a more verbose user error, we should do something like slice_error_fail from libstd/str.rs. Otherwise, it's just an assertion that adds more checks.
Remove redundant assertion near is_char_boundary Follow-up from #38056. `is_char_boundary` already checks for `idx <= len`, so, an extra assertion is redundant.
Follow-up from #38056.
is_char_boundaryalready checks foridx <= len, so, an extra assertion is redundant.