[MIR] Enhance the SimplifyCfg pass to merge consecutive blocks #29838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // example in a switch, it will appear in the target's predecessor list multiple | ||
| // times. This allows to update the map more easily when modifying the graph. | ||
| pub struct PredecessorMap { | ||
| map: Vec<Vec<BasicBlock>>, |
There was a problem hiding this comment.
As far as I can tell, this pass only cares about how many predecessors a block has, not what those predecessors are. It would be simpler and more efficient to just store a Vec<usize>.
|
☔ The latest upstream changes (presumably #29929) made this pull request unmergeable. Please resolve the merge conflicts. |
|
is this deprecated in favor of #30238? seems like it. |
|
I'm assuming yes, so I'll close for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @nikomatsakis