-
Notifications
You must be signed in to change notification settings - Fork 13.3k
fix #24968 more friend error message for Self
in fn args
#25096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
XuefengWu
wants to merge
72
commits into
rust-lang:master
from
XuefengWu:24968_err_msg_parse_self_type
Closed
Changes from 2 commits
Commits
Show all changes
72 commits
Select commit
Hold shift + click to select a range
3c503a5
more friend error message for in fn arg
XuefengWu 7ec6bd9
change Self type error message
XuefengWu f1ab664
rustc_back: Only use archive member filenames
alexcrichton e5efea4
Delete `_book` folder if it exists from previous runs
mdinger cce30b2
Remove errant line
tamird 5f932e8
make diagnostic message clearer when called from cargo
mathroc 4774d5d
Allow `T::C` syntax in match patterns to refer to trait-assosociated …
quantheory f548a05
Unignore some tests in stage1
tamird 809be9b
Fix link to RFC 255 in Reference.
b4bbf3a
Fix ICE that occurs when an associated const is ambiguous.
quantheory 556e76b
std: Redesign Duration, implementing RFC 1040
alexcrichton a4444aa
Add error explanations for E0066 and E0069.
44a5bf1
libstd/env: Add non-Rust synchronization warnings for setenv()
cgwalters 71f7fb2
Fix table syntax.
dreid 1b5b639
Auto merge of #25065 - quantheory:fix_associated_const_ambiguity_mess…
bors f539c41
Fix automatic substitution of task->thread.
dreid e77b03d
Auto merge of #25238 - alexcrichton:fix-archive-with-slashes, r=brson
bors 06aef33
Add error explanations for E0053, E0251, E0252, E0255, E0256, E0368.
0a1a53d
Auto merge of #24741 - cgwalters:note-setenv-and-unsetenv-are-not-thr…
bors d636b5c
Improve examples in the E0255/E0256 error explanations.
588777f
Improve E0053 and E0066 error explanations.
b1bd3a3
Auto merge of #25338 - tamird:unignore-stage-tests, r=alexcrichton
bors af52207
Auto merge of #25381 - mathroc:patch-1, r=alexcrichton
bors 62d0ef4
Fix crates.io link.
WiSaGaN ca225df
Rollup merge of #25354 - mdinger:delete_book, r=steveklabnik
Manishearth ab47005
Rollup merge of #25381 - mathroc:patch-1, r=alexcrichton
Manishearth 3ce4b99
Rollup merge of #25391 - nham:ref_rfc255_link, r=alexcrichton
Manishearth 0cbef04
Rollup merge of #25395 - dreid:patch-1, r=alexcrichton
Manishearth ff207b7
Rollup merge of #25397 - dreid:patch-2, r=alexcrichton
Manishearth 1109b6d
Rollup merge of #25398 - nham:E0066_E0069, r=huonw
Manishearth 2df7ae6
Rollup merge of #25401 - WiSaGaN:bugfix/fix_crates_io_link, r=stevekl…
Manishearth b4e1ce5
trpl-docs: Specify correct type of variable binding
dnaeon acb5e02
Another thread->task fix.
dreid e2bb734
trpl: punctuation fix
durka 90b9529
Move configuration 1 phase before crate metadata collection
lilyball 785cbe3
I fixed the typo of the value of e in the memory tables. It is a refe…
dd4dad8
Auto merge of #24920 - alexcrichton:duration, r=aturon
bors dc6eb78
trpl: fix link from Structs to Traits
durka 66c0fe0
trpl: fix link from Enums to Traits
durka c147ac4
trpl: fix link from Match to If Let
durka c8b0689
trpl: punctuation fix in Patterns
durka 4bdeb31
Add #[inline] to Borrow<str>::borrow for String.
koute a1577db
TRPL: Fix Internal Link
killercup 50fb669
s/Iterater/Iterator/
apasel422 571f371
Auto merge of #25403 - Manishearth:rollup, r=Manishearth
bors 82c7282
trpl: Fix missing internal links
leunggamciu 140577b
Don't use <Duration as Display>::display() in time passes
nrc 568f13a
Remove an almost-duplicated sentence.
habnabit 2792855
Auto merge of #25399 - kballard:crate-attributes-cfg_attr, r=alexcric…
bors 6e9e76a
Fix error codes E0197-E0200
cactorium 1f40cde
Rollup merge of #25404 - dnaeon:doc-fixes, r=steveklabnik
steveklabnik 0028f85
Rollup merge of #25405 - dreid:patch-3, r=nikomatsakis
steveklabnik c356211
Rollup merge of #25407 - durka:patch-1, r=alexcrichton
steveklabnik 765a55e
Rollup merge of #25408 - Nashenas88:rust-book-stack-and-heap-typo, r=…
steveklabnik dd60abc
Rollup merge of #25410 - durka:patch-2, r=steveklabnik
steveklabnik 609b4a1
Rollup merge of #25412 - koute:master, r=alexcrichton
steveklabnik aa56011
Rollup merge of #25413 - killercup:patch-11, r=alexcrichton
steveklabnik 8d52274
Rollup merge of #25414 - apasel422:patch-1, r=alexcrichton
steveklabnik 5501f07
Rollup merge of #25418 - leunggamciu:patch-trpl, r=steveklabnik
steveklabnik 6df13d4
Rollup merge of #25420 - habnabit:master, r=steveklabnik
steveklabnik 507f8b8
Fix merge conflict and also add markdown formatting
cactorium 0260333
Fix major compile time regression
dotdash daabc8a
Auto merge of #25421 - steveklabnik:rollup, r=steveklabnik
bors 0077ffe
Auto merge of #25419 - nrc:time, r=alexcrichton
bors 190de69
Add backticks around language keyword
cactorium 072cba9
Auto merge of #25422 - cactorium:unsafe_errors, r=huonw
bors 579e319
Auto merge of #25400 - nrc:save-api, r=huonw
bors 7ebaf1c
Auto merge of #25423 - dotdash:assume, r=huonw
bors a1d4648
more friend error message for in fn arg
XuefengWu eac661c
add compile test and update error message for Self keyworkd
XuefengWu 54f0828
Merge branch '24968_err_msg_parse_self_type' of github.com:XuefengWu/…
XuefengWu ba89495
fix typo for copyright year and trait capitalise
XuefengWu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Self
can also be used in a trait, so the message should include that. Also, you could add backticks around "Self".