Rollup of 13 pull requests #24481
Merged
Rollup of 13 pull requests #24481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
steveklabnik
commented
Apr 15, 2015
steveklabnik
commented
- Successful merges: disabling a test for bitrig and openbsd #24425, Remove Incorrect Link from std::ptr::null Docs #24435, Fix the span for tuple expressions #24438, Describe the Iterator enumerate() method more clearly. #24440, rustc: fix a typo in letter to rustc #24449, Fix some typos. #24457, Add tests for "ident only path should have been covered"-ICE #24460, Fix link in intoiterator docs #24465, Fix link formatting error #24467, Fix link to stack/heap page #24468, Fix link to rustbyexample.com #24471, Grammar fix #24476, Move IP related tests to ip.rs #24480
- Failed merges:
This commit modifies the socket creation functions on windows to always specify the `WSA_FLAG_OVERLAPPED` and `WSA_FLAG_NO_HANDLE_INHERIT` flags by default. The overlapped flag enables IOCP APIs on Windows to be used with the socket at no cost, enabling better interoperation with external libraries. The no handle inherit flag mirrors the upcoming change to Unix to set CLOEXEC by default for all handles. Closes rust-lang#24206
This commit removes the last remnants of file descriptors from the Windows implementation of `std::sys` by using `CreatePipe` to create anonymous pipes instead of the `pipe` shim provided in msvcrt.
The link works on the std::ptr docs page, but not the primitive.ptr.html page. Instead of leaving it half-broken, it is removed.
This resolves part of rust-lang#24407.
…ped, r=aturon This commit modifies the socket creation functions on windows to always specify the `WSA_FLAG_OVERLAPPED` and `WSA_FLAG_NO_HANDLE_INHERIT` flags by default. The overlapped flag enables IOCP APIs on Windows to be used with the socket at no cost, enabling better interoperation with external libraries. The no handle inherit flag mirrors the upcoming change to Unix to set CLOEXEC by default for all handles. Closes rust-lang#24206
This commit removes the last remnants of file descriptors from the Windows implementation of `std::sys` by using `CreatePipe` to create anonymous pipes instead of the `pipe` shim provided in msvcrt.
Had a newline in middle of a link, causing the link text to be shown with `[]`.
Link spanned a line and was mising the actual link target.
"as an library" -> "as a library"
…excrichton the code block in the no-stdlib.md file caused test failure on bitrig and openbsd. Closes rust-lang#24108
The link works on the `std/ptr/index.html` docs page, but not the `std/primitive.pointer.html` page. Instead of leaving it half-broken, it is removed. I tried fixing this in rust-lang#24432, but @alexcrichton mentioned that this doc string was used in two places (with different base paths unfortunately). r? @alexcrichton
…richton I found that the current description of `enumerate()` doesn't actually tell you what, specifically, the method does, and you have to look at the example to figure it out. Here's a description that I think is better.
Spotted a typo, opened a tiny PR.
Closes rust-lang#24197 Closes rust-lang#24375 These ICEs are fixed on nightly.
Had a newline in middle of a link, causing the link text to be shown with `[]`.
Link spanned a line and was missing the actual link target.
Use external instead of relative link for rustbyexample.com in generated `src/doc/index.md`. (http://doc.rust-lang.org/nightly/index.html) Previous: http://doc.rust-lang.org/nightly/rustbyexample.com Desired: http://rustbyexample.com/
"as an library" -> "as a library"
- Also move common functions to test.rs - Leaves out Socket address related tests in addr.rs
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ p=1 |
|
📌 Commit 7644ef8 has been approved by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.