Fixup for #22510 #22982
Closed
Fixup for #22510 #22982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you adjust the commit message so that it stands alone more (e.g. "Revert incorrect |
| @@ -283,7 +283,7 @@ impl Builder { | |||
| // address at which our stack started). | |||
| let main = move || { | |||
| let something_around_the_top_of_the_stack = 1; | |||
| let addr = &something_around_the_top_of_the_stack as *const isize; | |||
| let addr = &something_around_the_top_of_the_stack as *const i32; | |||
There was a problem hiding this comment.
It's irrelevant what something_around_the_top_of_the_stack is, so i32 is just okay.
|
Just need a small explanation there to confirm; though I suspect I understand what's going on. Also, agree with huon, a standalone message would be nice. Thanks! |
|
@Manishearth Reworded the commit message as suggested. |
|
@bors: rollup r+ |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Mar 3, 2015
|
⌛ Testing commit 22c204a with merge c330a54... |
|
💔 Test failed - auto-linux-64-nopt-t |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @Manishearth