Skip to content

Revert "enable parallel codegen by default" #18410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2014
Merged

Revert "enable parallel codegen by default" #18410

merged 1 commit into from
Oct 29, 2014

Conversation

thestinger
Copy link
Contributor

This reverts commit c245c5b.

Parallel code generation generates invalid code for librand, which is
caught by recent versions of binutils.

This reverts commit c245c5b.

Parallel code generation generates invalid code for librand, which is
caught by recent versions of binutils.
@thestinger
Copy link
Contributor Author

cc #18243

@alexcrichton
Copy link
Member

This is sad :(

@thestinger
Copy link
Contributor Author

Yeah, hopefully it's not too hard to fix this. The conflicts come from two #[inline] functions in rand::isaac. Perhaps the fix involves marking the instantiations of these with available_externally outside of the source codegen unit.

bors added a commit that referenced this pull request Oct 29, 2014
This reverts commit c245c5b.

Parallel code generation generates invalid code for librand, which is
caught by recent versions of binutils.
@bors bors closed this Oct 29, 2014
@bors bors merged commit 79723a3 into rust-lang:master Oct 29, 2014
@thestinger thestinger deleted the revert-parallel branch January 28, 2015 03:10
lnicola pushed a commit to lnicola/rust that referenced this pull request Oct 29, 2024
…qrxk

internal: Invert token iteration order in macro mapping
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants