Cleanup trans for structs with base expr. #16511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suspect this may have injected #23112 though I have not yet 100% confirmed |
|
In particular, it looks to me like this commit missed a crucial detail in the outline provided in #15397 : both strategies listed there maintain the evaluation order "fields first, then base", and the only issue is about which is initially put into scratch storage. This commit is avoiding scratch entirely by following an evaluation order of "base first, then fields." Of course, this does not jibe with the evaluation order that the borrow checker expects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15397.
Fixes #7261.
Fixes #6573.