Allow trailing comma in concat!
#15118
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(And in other extensions implemented with `get_exprs_from_tts` function).
| // allow trailing comma | ||
| if p.token != token::EOF { | ||
| es.push(cx.expand_expr(p.parse_expr())); | ||
| } |
There was a problem hiding this comment.
This loop should probably be restructured to look something like:
while p.token != token::EOF {
es.push(cx.expand_expr(p.parse_expr()));
if p.eat(&token::COMMA) { continue }
if p.token != token::EOF { /* error about trailing expressions */ }
}In general I don't think that the error expected token: "," should show up?
There was a problem hiding this comment.
@alexcrichton expected token: "," message looks correct to me. Can be suggest a better message?
|
Updated patch as suggested by @alexcrichton. |
bors
added a commit
that referenced
this pull request
Jun 24, 2014
(And in other extensions implemented with `get_exprs_from_tts` function).
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 17, 2023
…, r=Veykril Follow raw pointers in autoderef chain when resolving methods with custom receiver Fixes rust-lang#15083 I believe this stopped working after alexkirsz/rust-analyzer@e797479
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(And in other extensions implemented with
get_exprs_from_ttsfunction).