allow #[rustfmt::skip] in combination with #[naked]
#140626
Conversation
|
r? @fee1-dead rustbot has assigned @fee1-dead. Use |
rustbot
added
A-attributes
|
Some changes occurred in compiler/rustc_passes/src/check_attr.rs |
|
Would it make sense to generally allow all tool/proc_macro attributes and only restrict builtin attributes? |
|
Sometimes those are the same, I would need to recheck what the exact behavior is but these two sets could shadow eachother, if you try |
|
Yeah I don't seen an immediate way to rule out all builtin attributes. There is this |
|
Though I agree that we probably should only disallow builtin attributes and allow user proc macros. |
|
In any case, this is fine for now until we can find a better solution. I think the proper solution moving forward will be to have all function attributes properly handler the case of naked functions. @bors r+ |
bors
added
S-waiting-on-bors
Rollup of 7 pull requests Successful merges: - rust-lang#139675 (Add the AVX10 target features) - rust-lang#140286 (Check if format argument is identifier to avoid error err-emit) - rust-lang#140456 (Fix test simd/extract-insert-dyn on s390x) - rust-lang#140551 (Move some tests out of tests/ui) - rust-lang#140588 (Adjust some ui tests re. target-dependent errors) - rust-lang#140617 (Report the `unsafe_attr_outside_unsafe` lint at the closest node) - rust-lang#140626 (allow `#[rustfmt::skip]` in combination with `#[naked]`) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#140626 - folkertdev:naked-rustfmt-skip, r=Amanieu allow `#[rustfmt::skip]` in combination with `#[naked]` fixes rust-lang#140623 We very deliberately use an allowlist to prevent weird interactions with `#[naked]`, hopefully we've now found all of the useful combinations. cc `@Amanieu`
fixes #140623
We very deliberately use an allowlist to prevent weird interactions with
#[naked], hopefully we've now found all of the useful combinations.cc @Amanieu