Skip to content

crashes: more tests #139883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2025
Merged

crashes: more tests #139883

merged 1 commit into from
May 2, 2025
+332 −0

Conversation

matthiaskrgr
Copy link
Member

@matthiaskrgr matthiaskrgr commented Apr 15, 2025 •
edited
Loading

try-job: aarch64-apple
try-job: x86_64-msvc-1
try-job: x86_64-gnu
try-job: dist-i586-gnu-i586-i686-musl
try-job: test-various

@rustbot
Copy link
Collaborator

rustbot commented Apr 15, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 15, 2025
@matthiaskrgr
Copy link
Member Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 15, 2025
@bors
Auto merge of rust-lang#139883 - matthiaskrgr:crashesapr15, r=<try>
95883f1 
crashes: more tests

try-job: aarch64-apple
try-job: x86_64-msvc-1
try-job: x86_64-gnu
try-job: dist-i586-gnu-i586-i686-musl
@bors
Copy link
Collaborator

bors commented Apr 15, 2025

⌛ Trying commit 594f983 with merge 95883f1...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented Apr 15, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 15, 2025
@matthiaskrgr
Copy link
Member Author

@bors try

@bors
Copy link
Collaborator

bors commented Apr 15, 2025

⌛ Trying commit 756400b with merge 5df5b40...

bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 15, 2025
@bors
Auto merge of rust-lang#139883 - matthiaskrgr:crashesapr15, r=<try>
5df5b40 
crashes: more tests

try-job: aarch64-apple
try-job: x86_64-msvc-1
try-job: x86_64-gnu
try-job: dist-i586-gnu-i586-i686-musl
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented Apr 15, 2025

💔 Test failed - checks-actions

@matthiaskrgr
Copy link
Member Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 15, 2025
@bors
Auto merge of rust-lang#139883 - matthiaskrgr:crashesapr15, r=<try>
d323d43 
crashes: more tests

try-job: aarch64-apple
try-job: x86_64-msvc-1
try-job: x86_64-gnu
try-job: dist-i586-gnu-i586-i686-musl
@bors
Copy link
Collaborator

bors commented Apr 15, 2025

⌛ Trying commit f2534de with merge d323d43...

@bors
Copy link
Collaborator

bors commented Apr 16, 2025

☀️ Try build successful - checks-actions
Build commit: d323d43 (d323d4331436c279d3faaa5ea5eece1a44043a5e)

@matthiaskrgr
Copy link
Member Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 16, 2025
@matthiaskrgr matthiaskrgr marked this pull request as ready for review April 16, 2025 05:07
@rustbot
Copy link
Collaborator

rustbot commented Apr 16, 2025

This PR changes a file inside tests/crashes. If a crash was fixed, please move into the corresponding ui subdir and add 'Fixes #' to the PR description to autoclose the issue upon merge.

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 27, 2025

📌 Commit f2534de has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 27, 2025
@matthiaskrgr
Copy link
Member Author

ignored the test on apple x86_64 darwin
@bors r=Mark-Simulacrum

@bors
Copy link
Collaborator

bors commented Apr 29, 2025

📌 Commit 4034caf has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 29, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Apr 29, 2025
@Zalathar
Rollup merge of rust-lang#139883 - matthiaskrgr:crashesapr15, r=Mark-…
1b3e1a2 
…Simulacrum

crashes: more tests

try-job: aarch64-apple
try-job: x86_64-msvc-1
try-job: x86_64-gnu
try-job: dist-i586-gnu-i586-i686-musl
@Zalathar Zalathar mentioned this pull request Apr 29, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 29, 2025
@bors
Auto merge of rust-lang#140444 - Zalathar:rollup-pbefd89, r=Zalathar
d635125 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#139883 (crashes: more tests)
 - rust-lang#140312 (Improve pretty-printing of braces)
 - rust-lang#140392 (compiletest: Remove the libtest-based executor and its dependency)
 - rust-lang#140395 (organize and extend forbidden target feature tests)
 - rust-lang#140422 (unwind: bump `unwinding` dependency to 0.2.6)
 - rust-lang#140432 (Update documentation for `fn target_config`)

r? `@ghost`
`@rustbot` modify labels: rollup
@Zalathar
Copy link
Contributor

Failed in rollup: #140444 (comment)

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 29, 2025
@matthiaskrgr
Copy link
Member Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request May 1, 2025
@bors
Auto merge of rust-lang#139883 - matthiaskrgr:crashesapr15, r=<try>
fa05176 
crashes: more tests

try-job: aarch64-apple
try-job: x86_64-msvc-1
try-job: x86_64-gnu
try-job: dist-i586-gnu-i586-i686-musl
try-job: test-various
@bors
Copy link
Collaborator

bors commented May 1, 2025

⌛ Trying commit c1f2ad2 with merge fa05176...

@bors
Copy link
Collaborator

bors commented May 1, 2025

☀️ Try build successful - checks-actions
Build commit: fa05176 (fa05176e94ed3ec4657fe71eeea5d08623f2829a)

@matthiaskrgr
Copy link
Member Author

@bors r=Mark-Simulacrum

@bors
Copy link
Collaborator

bors commented May 1, 2025

📌 Commit c1f2ad2 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 1, 2025
VlaDexa added a commit to VlaDexa/rust that referenced this pull request May 2, 2025
@VlaDexa
Rollup merge of rust-lang#139883 - matthiaskrgr:crashesapr15, r=Mark-…
7411639 
…Simulacrum

crashes: more tests

try-job: aarch64-apple
try-job: x86_64-msvc-1
try-job: x86_64-gnu
try-job: dist-i586-gnu-i586-i686-musl
try-job: test-various
@VlaDexa VlaDexa mentioned this pull request May 2, 2025
Closed
@bors
Copy link
Collaborator

bors commented May 2, 2025

⌛ Testing commit c1f2ad2 with merge f97b3c6...

@bors
Copy link
Collaborator

bors commented May 2, 2025

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing f97b3c6 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 2, 2025
@bors bors merged commit f97b3c6 into rust-lang:master May 2, 2025
7 checks passed
@rustbot rustbot added this to the 1.88.0 milestone May 2, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing db074a0 (parent) -> f97b3c6 (this PR)

Test differences

Show 53 test diffs

Stage 1

  • [crashes] tests/crashes/138156.rs: [missing] -> pass (J3)
  • [crashes] tests/crashes/138240.rs: [missing] -> pass (J3)
  • [crashes] tests/crashes/138265.rs: [missing] -> pass (J3)
  • [crashes] tests/crashes/138266.rs: [missing] -> pass (J3)
  • [crashes] tests/crashes/138359.rs: [missing] -> pass (J3)
  • [crashes] tests/crashes/138361.rs: [missing] -> pass (J3)
  • [crashes] tests/crashes/138510.rs: [missing] -> pass (J3)
  • [crashes] tests/crashes/138534.rs: [missing] -> pass (J3)
  • [crashes] tests/crashes/138564.rs: [missing] -> pass (J3)
  • [crashes] tests/crashes/138707.rs: [missing] -> pass (J3)
  • [crashes] tests/crashes/138738.rs: [missing] -> pass (J3)
  • [crashes] tests/crashes/139089.rs: [missing] -> pass (J3)
  • [crashes] tests/crashes/139120.rs: [missing] -> pass (J3)
  • [crashes] tests/crashes/139381.rs: [missing] -> pass (J3)
  • [crashes] tests/crashes/139387.rs: [missing] -> pass (J3)
  • [crashes] tests/crashes/139409.rs: [missing] -> pass (J3)
  • [crashes] tests/crashes/139462.rs: [missing] -> pass (J3)
  • [crashes] tests/crashes/139556.rs: [missing] -> pass (J3)
  • [crashes] tests/crashes/139570.rs: [missing] -> pass (J3)
  • [crashes] tests/crashes/139596.rs: [missing] -> pass (J3)
  • [crashes] tests/crashes/139659.rs: [missing] -> pass (J3)
  • [crashes] tests/crashes/139738.rs: [missing] -> pass (J3)
  • [crashes] tests/crashes/139815.rs: [missing] -> pass (J3)
  • [crashes] tests/crashes/139817.rs: [missing] -> pass (J3)
  • [crashes] tests/crashes/139825.rs: [missing] -> pass (J3)

Stage 2

  • [crashes] tests/crashes/138156.rs: [missing] -> pass (J0)
  • [crashes] tests/crashes/138240.rs: [missing] -> pass (J0)
  • [crashes] tests/crashes/138265.rs: [missing] -> pass (J0)
  • [crashes] tests/crashes/138266.rs: [missing] -> pass (J0)
  • [crashes] tests/crashes/138359.rs: [missing] -> pass (J0)
  • [crashes] tests/crashes/138361.rs: [missing] -> pass (J0)
  • [crashes] tests/crashes/138510.rs: [missing] -> pass (J0)
  • [crashes] tests/crashes/138534.rs: [missing] -> pass (J0)
  • [crashes] tests/crashes/138564.rs: [missing] -> pass (J0)
  • [crashes] tests/crashes/138707.rs: [missing] -> pass (J0)
  • [crashes] tests/crashes/139089.rs: [missing] -> pass (J0)
  • [crashes] tests/crashes/139120.rs: [missing] -> pass (J0)
  • [crashes] tests/crashes/139409.rs: [missing] -> pass (J0)
  • [crashes] tests/crashes/139462.rs: [missing] -> pass (J0)
  • [crashes] tests/crashes/139556.rs: [missing] -> pass (J0)
  • [crashes] tests/crashes/139570.rs: [missing] -> pass (J0)
  • [crashes] tests/crashes/139596.rs: [missing] -> pass (J0)
  • [crashes] tests/crashes/139659.rs: [missing] -> pass (J0)
  • [crashes] tests/crashes/139738.rs: [missing] -> pass (J0)
  • [crashes] tests/crashes/139815.rs: [missing] -> pass (J0)
  • [crashes] tests/crashes/139817.rs: [missing] -> pass (J0)
  • [crashes] tests/crashes/139825.rs: [missing] -> pass (J0)
  • [crashes] tests/crashes/138738.rs: [missing] -> ignore (only executed when the architecture is x86_64) (J1)
  • [crashes] tests/crashes/139381.rs: [missing] -> ignore (ignored if rustc wasn't built with debug assertions) (J2)
  • [crashes] tests/crashes/139387.rs: [missing] -> ignore (ignored if rustc wasn't built with debug assertions) (J2)
  • [crashes] tests/crashes/138738.rs: [missing] -> pass (J4)
  • [crashes] tests/crashes/139381.rs: [missing] -> pass (J5)
  • [crashes] tests/crashes/139387.rs: [missing] -> pass (J5)

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard f97b3c6044a67e0b5d0d0891ca3a6c5d982b2285 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-apple-1: 6621.1s -> 5292.3s (-20.1%)
  2. dist-x86_64-apple: 9241.8s -> 8029.7s (-13.1%)
  3. dist-powerpc64le-linux: 9599.5s -> 10488.9s (9.3%)
  4. dist-apple-various: 7266.3s -> 6752.3s (-7.1%)
  5. dist-x86_64-mingw: 8158.9s -> 7609.8s (-6.7%)
  6. dist-arm-linux: 4705.4s -> 5020.8s (6.7%)
  7. x86_64-gnu-aux: 4161.3s -> 4411.7s (6.0%)
  8. x86_64-gnu-nopt: 5472.3s -> 5752.5s (5.1%)
  9. dist-s390x-linux: 5417.8s -> 5183.4s (-4.3%)
  10. x86_64-msvc-ext1: 7362.3s -> 7044.9s (-4.3%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (f97b3c6): comparison URL.

Overall result: ❌ regressions - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

  • If the regression was expected or you think it can be justified,
    please write a comment with sufficient written justification, and add
    @rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
  • If you think that you know of a way to resolve the regression, try to create
    a new PR with a fix for the regression.
  • If you do not understand the regression or you think that it is just noise,
    you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
    were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)		 1.2% [1.2%, 1.2%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 1.2% [1.2%, 1.2%] 1

Max RSS (memory usage)

Results (primary 0.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.9% [0.4%, 2.6%] 6
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -1.1% [-2.3%, -0.5%] 5
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.0% [-2.3%, 2.6%] 11

Cycles

Results (primary -0.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.7% [0.5%, 1.0%] 4
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -1.2% [-4.4%, -0.4%] 13
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.8% [-4.4%, 1.0%] 17

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 767.923s -> 766.288s (-0.21%)
Artifact size: 365.55 MiB -> 365.55 MiB (0.00%)

@rustbot rustbot added the perf-regression Performance regression. label May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.88.0
Development

Successfully merging this pull request may close these issues.
8 participants
@matthiaskrgr @rustbot @bors @rust-log-analyzer @Mark-Simulacrum @ChrisDenton @Zalathar @rust-timer