Skip to content

rename sub_ptr to offset_from_unsigned #137483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 24, 2025
Merged

rename sub_ptr to offset_from_unsigned #137483

merged 1 commit into from
Feb 24, 2025

Conversation

bend-n
Copy link
Contributor

@bend-n bend-n commented Feb 23, 2025 •
edited
Loading

i also made byte_sub_ptr byte_offset_from_unsigned

fixes #137121
tracking issue #95892

@rustbot
Copy link
Collaborator

rustbot commented Feb 23, 2025

r? @workingjubilee

rustbot has assigned @workingjubilee.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 23, 2025
@rustbot
Copy link
Collaborator

rustbot commented Feb 23, 2025

The Miri subtree was changed

cc @rust-lang/miri

@rustbot rustbot assigned Noratrieb and unassigned workingjubilee Feb 23, 2025
@rustbot
Copy link
Collaborator

rustbot commented Feb 23, 2025

Could not assign reviewer from: Noratrieb.
User(s) Noratrieb are either the PR author, already assigned, or on vacation. Please use r? to specify someone else to assign.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bend-n bend-n force-pushed the 😅 branch 2 times, most recently from b83ae9a to 4e23cbe Compare February 23, 2025 14:05
@RalfJung
Copy link
Member

I guess this will also be a test whether GH and all our tooling can deal with an emoji branch name. There have been problems in the past.^^

@bend-n bend-n force-pushed the 😅 branch 3 times, most recently from 0869572 to c37e497 Compare February 23, 2025 14:24
@Noratrieb
Copy link
Member

yeahh, please add at least one ascii character to the branch name, or it will end badly probably

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@RalfJung
Copy link
Member

RalfJung commented Feb 23, 2025 •
edited
Loading

The branches a PR is on can't be changed, so that would require a new PR. But we can also just try?^^ So far it seems to work.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jieyouxu jieyouxu mentioned this pull request Feb 23, 2025
Merged
@Noratrieb Noratrieb mentioned this pull request Feb 23, 2025
Closed
5 tasks
@Noratrieb
Copy link
Member

let's see if this fails horribly due to the branch name ^^'. thanks for the PR!
@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Feb 23, 2025

📌 Commit c813d8f has been approved by Noratrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 23, 2025
@tgross35 tgross35 mentioned this pull request Feb 23, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 23, 2025
@bors
Auto merge of rust-lang#137497 - tgross35:rollup-1oeclrr, r=tgross35
246632c 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#136439 (Misc. `rustc_codegen_ssa` cleanups 🧹)
 - rust-lang#136543 (intrinsics: unify rint, roundeven, nearbyint in a single round_ties_even intrinsic)
 - rust-lang#136637 (Add binary_format to rustc target specs)
 - rust-lang#137099 (Fix rustdoc test directives that were accidentally ignored 🧐)
 - rust-lang#137297 (Update `compiler-builtins` to 0.1.147)
 - rust-lang#137451 (FIx `sym` -> `syn` typo in tail-expr-drop-order type opt-out)
 - rust-lang#137452 (bootstrap: add module docs for core:metadata)
 - rust-lang#137483 (rename sub_ptr to offset_from_unsigned)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 18ffee2 into rust-lang:master Feb 24, 2025
6 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Feb 24, 2025
@carolynzech carolynzech mentioned this pull request Feb 27, 2025
Merged
@DaniPopes DaniPopes mentioned this pull request Apr 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalfJung RalfJung RalfJung left review comments

Assignees

@Noratrieb Noratrieb

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.87.0
Development

Successfully merging this pull request may close these issues.
7 participants
@bend-n @rustbot @rust-log-analyzer @RalfJung @Noratrieb @bors @workingjubilee