Skip to content

stabilize const_ptr_is_null #133116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 17, 2024
Merged

stabilize const_ptr_is_null #133116

merged 2 commits into from
Nov 17, 2024

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Nov 16, 2024

FCP passed in #74939.

The second commit cleans up const stability around UB checks a bit, now that everything they need (except for const_eval_select) is stable.

Fixes #74939

@rustbot
Copy link
Collaborator

rustbot commented Nov 16, 2024

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 16, 2024
@rustbot
Copy link
Collaborator

rustbot commented Nov 16, 2024

Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter
gets adapted for the changes, if necessary.

cc @rust-lang/miri, @rust-lang/wg-const-eval

@rustbot
Copy link
Collaborator

rustbot commented Nov 16, 2024

Some changes occurred to the CTFE machinery

cc @rust-lang/wg-const-eval

@rust-log-analyzer

This comment has been minimized.

@dtolnay
Copy link
Member

dtolnay commented Nov 16, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 16, 2024

📌 Commit 543627d has been approved by dtolnay

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Nov 16, 2024

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 16, 2024
@dtolnay dtolnay assigned dtolnay and unassigned tgross35 Nov 16, 2024
@bors bors merged commit af1c8be into rust-lang:master Nov 17, 2024
6 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Nov 17, 2024
@RalfJung RalfJung deleted the const-null-ptr branch November 18, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking issue for const <*const T>::is_null
6 participants