-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Fix false positive with missing_docs
and #[test]
#130219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixes #130216 |
This comment has been minimized.
This comment has been minimized.
Since rust-lang#130025, the compiler don't ignore missing_docs when compiling the tests. But there is now a false positive warning for every `#[test]` For example, this code ```rust //! Crate docs fn just_a_test() {} ``` Would emit this warning when running `cargo test` ``` warning: missing documentation for a constant --> src/lib.rs:5:1 | 4 | #[test] | ------- in this procedural macro expansion 5 | fn just_a_test() {} | ^^^^^^^^^^^^^^^^^^^ ```
f6fe6eb
to
6eddbb7
Compare
Alternative would be to add Edit: I went for this option. |
… generated for `#[test]`
Could you also change the |
So that it doesn't fail with `forbid(missing_docs)` Fixes rust-lang#130218
Done |
@rustbot review |
Thanks! @bors r+ rollup |
Since #130025, the compiler don't ignore missing_docs when compiling the tests. But there is now a false positive warning for every
#[test]
For example, this code
Would emit this warning when running
cargo test