Code

Clippy subtree update#128193

Code

Merged

bors merged 141 commits intorust-lang:masterrust-lang/rust:masterfrom

flip1995:clippy-subtree-updateflip1995/rust:clippy-subtree-updateCopy head branch name to clipboard

Jul 26, 2024

Commits

Commits on Jul 5, 2024

• Refactor `arc_with_non_send_sync`

  Show description for dd9e8c8
  Jarcho

  committed
  dd9e8c8

  Copy full SHA for dd9e8c8

• Refactor `borrow_deref_ref`: Match HIR tree before checking for macros.

  Jarcho

  committed
  01f53c2

  Copy full SHA for 01f53c2

• Refactor `collapsible_if`: Check AST before checking for macros

  Jarcho

  committed
  39cd58e

  Copy full SHA for 39cd58e

• Refactor `collection_is_never_read`: Check HIR tree before checking types.

  Jarcho

  committed
  1f530ab

  Copy full SHA for 1f530ab

• Refactor `crate_in_macro_def`:

  Show description for d15ec0f
  Jarcho

  committed
  d15ec0f

  Copy full SHA for d15ec0f

• Refactor `else_if_without_else`: Check the AST before the macro check.

  Jarcho

  committed
  441500b

  Copy full SHA for 441500b

• `equatable_if_let`: Check HIR tree before checking for macros.

  Jarcho

  committed
  d1dcd91

  Copy full SHA for d1dcd91

• Refactor `empty_enums`: Check the HIR tree before the feature check.

  Jarcho

  committed
  672b8b5

  Copy full SHA for 672b8b5

• `error_impl_error`: Get `Error` `DefId` after checking the HIR tree.

  Jarcho

  committed
  5b0dac6

  Copy full SHA for 5b0dac6

• `exhaustive_items`: Don't check the item kind twice.

  Jarcho

  committed
  5368895

  Copy full SHA for 5368895

• `exit`: Use `OwnerNode`.

  Jarcho

  committed
  ca7e5c1

  Copy full SHA for ca7e5c1

• `float_literal`: Check HIR tree before checking types.

  Jarcho

  committed
  278e837

  Copy full SHA for 278e837

• `from_over_into`: Check HIR tree first.

  Jarcho

  committed
  3fcac2c

  Copy full SHA for 3fcac2c

• `from_str_radix_10` : Reorder checks

  Jarcho

  committed
  9f59e9a

  Copy full SHA for 9f59e9a

Commits on Jul 7, 2024

• Refactor `checked_conversions`:

  Show description for 65b9fae
  Jarcho

  committed
  65b9fae

  Copy full SHA for 65b9fae

• Refactor `double_parens`:

  Show description for 0a25df8
  Jarcho

  committed
  0a25df8

  Copy full SHA for 0a25df8

• Add test for manual_unwrap_or in issue 13018

  tesuji

  committed
  e864519

  Copy full SHA for e864519

• Fix 13018: self should be T

  Show description for c46c1f6
  tesuji

  committed
  c46c1f6

  Copy full SHA for c46c1f6

• Refactor `endian_bytes`:

  Show description for 1b0230c
  Jarcho

  committed
  1b0230c

  Copy full SHA for 1b0230c

• Refactor `excessive_bools`:

  Show description for f178316
  Jarcho

  committed
  f178316

  Copy full SHA for f178316

• `extra_unused_type_parameters`:

  Show description for d409b5c
  Jarcho

  committed
  d409b5c

  Copy full SHA for d409b5c

• Refactor `future_not_send`

  Jarcho

  committed
  c32af26

  Copy full SHA for c32af26

• `if_let_mutex`: Use `for_each_expr`.

  Jarcho

  committed
  776a523

  Copy full SHA for 776a523

• Refactor `if_not_else`:

  Show description for b26b820
  Jarcho

  committed
  b26b820

  Copy full SHA for b26b820

• `if_then_some_else_none`: Check HIR tree before other checks.

  Jarcho

  committed
  517e1ac

  Copy full SHA for 517e1ac

• `ignored_unit_patterns`: Reorder checks.

  Jarcho

  committed
  3869e93

  Copy full SHA for 3869e93

• `inconsistent_struct_constructor`: Check HIR tree first.

  Jarcho

  committed
  b58b491

  Copy full SHA for b58b491

• `index_refutable_slice`: Check HIR tree first.

  Jarcho

  committed
  06f83b4

  Copy full SHA for 06f83b4

• `indexing_slicing`: Check HIR tree first.

  Jarcho

  committed
  c73aceb

  Copy full SHA for c73aceb

• `infinite_iter`: Only lock the symbol table once.

  Jarcho

  committed
  f493d71

  Copy full SHA for f493d71

Commits on Jul 8, 2024

• `misc`:

  Show description for 36a14e3
  Jarcho

  committed
  36a14e3

  Copy full SHA for 36a14e3

• `mismatching_type_param_order`: Delay macro check.

  Jarcho

  committed
  58aa804

  Copy full SHA for 58aa804

• `needless_borrowed_ref`: Check HIR tree first.

  Jarcho

  committed
  c226088

  Copy full SHA for c226088

• `mut_mut`: Delay macro check

  Jarcho

  committed
  139dad8

  Copy full SHA for 139dad8

• `needless_for_each`: Check HIR tree first.

  Jarcho

  committed
  7c17dd3

  Copy full SHA for 7c17dd3

• `neg_cmp_op_on_partial_ord`: Delay macro check

  Jarcho

  committed
  ff28de2

  Copy full SHA for ff28de2

• Simplify `option_env_unwrap`.

  Jarcho

  committed
  15eac5a

  Copy full SHA for 15eac5a

• `permissions_set_readonly_false`: Check HIR tree first.

  Jarcho

  committed
  e12ff63

  Copy full SHA for e12ff63

• `raw_strings` Check HIR tree first.

  Jarcho

  committed
  0c72a99

  Copy full SHA for 0c72a99

Commits on Jul 9, 2024

• unnecessary_struct_initialization: extend to assignments moving all fields

  Show description for 296dcf0
  phi-gamma

  committed
  296dcf0

  Copy full SHA for 296dcf0

• Lintcheck: Refactor `CrateSource`

  xFrednet

  committed
  601a61f

  Copy full SHA for 601a61f

Commits on Jul 11, 2024

• Merge commit 'b794b8e08c16517a941dc598bb1483e8e12a8592' into clippy-subtree-update

  flip1995

  committed
  c1fd25d

  Copy full SHA for c1fd25d

• Add Expand All and Collapse All

  

  SpencerAWill

  authored and

  xFrednet

  committed
  d5e1aca

  Copy full SHA for d5e1aca

• Fix button styling on desktop and mobile views.

  

  SpencerAWill

  authored and

  xFrednet

  committed
  8bfd992

  Copy full SHA for 8bfd992

• Remove event propagation calls. Adjust column spacing for filter panel to give more space for buttons on smaller screens.

  

  SpencerAWill

  authored and

  xFrednet

  committed
  6ae5fd9

  Copy full SHA for 6ae5fd9

• Auto merge of #12656 - SpencerAWill:Add-expand-all-to-the-web-site, r=xFrednet

  Show description for 86d348d
  bors

  committed
  86d348d

  Copy full SHA for 86d348d

Commits on Jul 12, 2024

• Fix syntax errors in example code

  flba-eb

  committed
  edeb0fc

  Copy full SHA for edeb0fc

• [`unwrap_or_default`]: skip warning when calling inside of suggested method's implementation

  J-ZhengLi

  committed
  983b4c3

  Copy full SHA for 983b4c3

• Auto merge of #13089 - flba-eb:fix_example, r=y21

  Show description for 51a1cf0
  bors

  committed
  51a1cf0

  Copy full SHA for 51a1cf0

• Auto merge of #13090 - J-ZhengLi:issue9790, r=blyxyas

  Show description for 0cbbee1
  bors

  committed
  0cbbee1

  Copy full SHA for 0cbbee1

Commits on Jul 13, 2024

• Add more doc-valid-idents

  Show description for 39378cf
  waywardmonkeys

  committed
  39378cf

  Copy full SHA for 39378cf

• make [`or_fun_call`] and [`unwrap_or_default`] recursive.

  J-ZhengLi

  committed
  cc1bb8f

  Copy full SHA for cc1bb8f

• Auto merge of #13085 - J-ZhengLi:issue12973, r=llogiq

  Show description for 1aac778
  bors

  committed
  1aac778

  Copy full SHA for 1aac778

• Auto merge of #13061 - tesuji:fix-map-unwrap-or-13018, r=dswij

  Show description for e7d17e6
  bors

  committed
  e7d17e6

  Copy full SHA for e7d17e6

• Auto merge of #13046 - Jarcho:check_conv, r=dswij

  Show description for 206e4ad
  bors

  committed
  206e4ad

  Copy full SHA for 206e4ad

Commits on Jul 14, 2024

• Auto merge of #13093 - waywardmonkeys:more-doc-valid-idents, r=Alexendoo

  Show description for 10ba798
  bors

  committed
  10ba798

  Copy full SHA for 10ba798

• Fix trivial gen ident usage in tools

  compiler-errors

  committed
  185f4b0

  Copy full SHA for 185f4b0

Commits on Jul 15, 2024

• Bump clippy version

  oli-obk

  committed
  3b390d4

  Copy full SHA for 3b390d4

• Auto merge of #13098 - oli-obk:bump_ui_test, r=Alexendoo

  Show description for 22eeb11
  bors

  committed
  22eeb11

  Copy full SHA for 22eeb11

• Add regression test for issue 13077

  tesuji

  committed
  4264548

  Copy full SHA for 4264548

• Dont stop find loop node at struct field node

  tesuji

  committed
  dcee2e8

  Copy full SHA for dcee2e8

• Auto merge of #13102 - tesuji:fix-needless_option_as_deref, r=Alexendoo

  Show description for eb4d88e
  bors

  committed
  eb4d88e

  Copy full SHA for eb4d88e

• fix [`excessive_precision`] suggestions on float literal written in scientific notation

  Show description for 489a778
  apoisternex

  committed
  489a778

  Copy full SHA for 489a778

Commits on Jul 16, 2024

• Move rustc_infer::infer::error_reporting to rustc_infer::error_reporting::infer

  compiler-errors

  committed
  c1c945a

  Copy full SHA for c1c945a

• Auto merge of #13096 - apoisternex:issue12954, r=y21

  Show description for 0ee9f44
  bors

  committed
  0ee9f44

  Copy full SHA for 0ee9f44

Commits on Jul 17, 2024

• hir: Create `hir::ConstArgKind` enum

  Show description for 620a056
  camelid

  committed
  620a056

  Copy full SHA for 620a056

• Use `ConstArg` for array lengths

  camelid

  committed
  6e99e2d

  Copy full SHA for 6e99e2d

• Add `ConstArgKind::Path` and make `ConstArg` its own HIR node

  Show description for f2c1265
  camelid

  committed
  f2c1265

  Copy full SHA for f2c1265

• Add regression test for issue 13110

  tesuji

  committed
  c65ddb8

  Copy full SHA for c65ddb8

• Skip linting if array length is from a macro.

  tesuji

  committed
  5540060

  Copy full SHA for 5540060

• Show progress while running dogfood test

  Alexendoo

  committed
  0b0c39c

  Copy full SHA for 0b0c39c

• Refactor for using config values:

  Show description for e34c6db
  Jarcho

  committed
  e34c6db

  Copy full SHA for e34c6db

• Auto merge of #13088 - Jarcho:conf_refactor2, r=flip1995

  Show description for f74037e
  bors

  committed
  f74037e

  Copy full SHA for f74037e

• Auto merge of #13100 - Alexendoo:dogfood-progress, r=xFrednet

  Show description for acc41f4
  bors

  committed
  acc41f4

  Copy full SHA for acc41f4

Commits on Jul 18, 2024

• Lint only if array length is a literal zero.

  tesuji

  committed
  3c50e7a

  Copy full SHA for 3c50e7a

• valtree construction: keep track of which type was valtree-incompatible

  RalfJung

  committed
  b0209dc

  Copy full SHA for b0209dc

• Auto merge of #13116 - tesuji:fix_zero_repeat_side_effects, r=y21

  Show description for 073f9d9
  bors

  committed
  073f9d9

  Copy full SHA for 073f9d9

• Fix wrong suggestion for `single_element_loop` where parens were missing

  GuillaumeGomez

  committed
  8dd310d

  Copy full SHA for 8dd310d

• Auto merge of #13117 - GuillaumeGomez:fix-single_element_loop-suggestion, r=Alexendoo

  Show description for bc2feea
  bors

  committed
  bc2feea

  Copy full SHA for bc2feea

• Lintcheck: Construct links for sources

  xFrednet

  committed
  0e3d197

  Copy full SHA for 0e3d197

• Auto merge of #13104 - xFrednet:00000-lintcheck-better-md-links, r=Alexendoo

  Show description for b31bce4
  bors

  committed
  b31bce4

  Copy full SHA for b31bce4

• Lintcheck: Remove `rust-toolchain` from downloaded crates

  xFrednet

  committed
  31fdc2e

  Copy full SHA for 31fdc2e

• Lintcheck: More info on Diags without spans

  xFrednet

  committed
  9d82fb4

  Copy full SHA for 9d82fb4

• Update version attribute for 1.80 lints

  xFrednet

  committed
  e34db99

  Copy full SHA for e34db99

• Changelog for Clippy 1.80 :sun_with_face:

  xFrednet

  committed
  642ab11

  Copy full SHA for 642ab11

• Make clippy and rustdoc happy

  compiler-errors

  committed
  8a0ccd3

  Copy full SHA for 8a0ccd3

Commits on Jul 19, 2024

• Auto merge of #125915 - camelid:const-arg-refactor, r=BoxyUwU

  Show description for 8051d07
  bors

  committed
  8051d07

  Copy full SHA for 8051d07

• Triagebot: Add xFrednet back to Clippy's reviewer roulette

  xFrednet

  committed
  14e2711

  Copy full SHA for 14e2711

• Auto merge of #13129 - xFrednet:interesting-life-choices, r=xFrednet

  Show description for ac2ba15
  bors

  committed
  ac2ba15

  Copy full SHA for ac2ba15

• Lintcheck: Normalize thread IDs in shared_target_dir

  xFrednet

  committed
  46ebe0c

  Copy full SHA for 46ebe0c

• Lintcheck: Update the default testset for local lintcheck

  xFrednet

  committed
  4ece12d

  Copy full SHA for 4ece12d

• Lintcheck: New testset for Clippy's CI (200 crates for ~10 min)

  xFrednet

  committed
  8940bc3

  Copy full SHA for 8940bc3

• Auto merge of #13124 - xFrednet:00000-lintcheck-crates, r=Alexendoo

  Show description for 057c4ae
  bors

  committed
  057c4ae

  Copy full SHA for 057c4ae

Commits on Jul 20, 2024

• Reduce typo count.

  waywardmonkeys

  committed
  cf4270d

  Copy full SHA for cf4270d

• Auto merge of #13131 - waywardmonkeys:reduce-typo-count, r=Alexendoo

  Show description for b02cb24
  bors

  committed
  b02cb24

  Copy full SHA for b02cb24

• Lintcheck: Linkify counts in CI summery

  xFrednet

  committed
  09906b8

  Copy full SHA for 09906b8

• Lintcheck: Remove empty lines from rendered CI output

  xFrednet

  committed
  83c8385

  Copy full SHA for 83c8385

• Lintcheck: Include the crate name in the CI job summary

  xFrednet

  committed
  69c3289

  Copy full SHA for 69c3289

Commits on Jul 21, 2024

• [`pathbuf_init_then_push`]: Checks for calls to `push` immediately after creating a new `PathBuf`

  Show description for cb77f12
  

  lengyijun

  and

  xFrednet

  committed
  cb77f12

  Copy full SHA for cb77f12

• Auto merge of #11700 - lengyijun:pathbuf_join, r=xFrednet

  Show description for 8fe5c75
  bors

  committed
  8fe5c75

  Copy full SHA for 8fe5c75

• Auto merge of #13133 - xFrednet:lintcheck-linkify-summary, r=Alexendoo

  Show description for 7f0ed11
  bors

  committed
  7f0ed11

  Copy full SHA for 7f0ed11

• Auto merge of #120812 - compiler-errors:impl-sorting, r=lcnr

  Show description for 5f3d385
  bors

  committed
  5f3d385

  Copy full SHA for 5f3d385

• Auto merge of #12772 - phi-gamma:redundant-struct-recreation, r=y21

  Show description for 1807580
  bors

  committed
  1807580

  Copy full SHA for 1807580

Commits on Jul 22, 2024

• Move all error reporting into rustc_trait_selection

  compiler-errors

  committed
  897c4d3

  Copy full SHA for 897c4d3

• Fix tools

  compiler-errors

  committed
  efde1c0

  Copy full SHA for efde1c0

• Sync `mut_visit` function names with immut `visit` ones (s/noop_visit/walk/)

  oli-obk

  committed
  3149037

  Copy full SHA for 3149037

• Always pass the visitor as the first argument to walk* functions

  oli-obk

  committed
  221ac86

  Copy full SHA for 221ac86

• Lintcheck: Limit summary size to 1024k and copy to logs

  xFrednet

  committed
  4798383

  Copy full SHA for 4798383

• Lintcheck: Order summary by lint and truncate messages

  xFrednet

  committed
  4fea519

  Copy full SHA for 4fea519

• Lintcheck: Minor cleanup and function moves

  xFrednet

  committed
  1f879fc

  Copy full SHA for 1f879fc

• Lintcheck: Include truncated diff in CI artifacts

  xFrednet

  committed
  10bf729

  Copy full SHA for 10bf729

• Lintcheck: Fix Errors, because of course

  xFrednet

  committed
  23b231a

  Copy full SHA for 23b231a

• Suggest `.cast`/`.cast_const`/`.cast_mut` in `transmute_ptr_as_ptr`

  Alexendoo

  committed
  afe811a

  Copy full SHA for afe811a

• Auto merge of #13065 - Jarcho:misc_small2, r=xFrednet

  Show description for 637d39f
  bors

  committed
  637d39f

  Copy full SHA for 637d39f

• Auto merge of #13072 - Jarcho:misc_small5, r=xFrednet

  Show description for f9c2407
  bors

  committed
  f9c2407

  Copy full SHA for f9c2407

• Get rid of infer_ctxt_ext

  compiler-errors

  committed
  e2a7000

  Copy full SHA for e2a7000

• Auto merge of #13050 - Jarcho:misc_small, r=xFrednet

  Show description for df1baed
  bors

  committed
  df1baed

  Copy full SHA for df1baed

Commits on Jul 23, 2024

• Lintcheck: Support underscores replacement in URL crate names

  xFrednet

  committed
  04693a4

  Copy full SHA for 04693a4

• Don't suggest `.cast_mut`/`.cast_const` for types with erased lifetimes

  Alexendoo

  committed
  7010d3c

  Copy full SHA for 7010d3c

• Auto merge of #13148 - xFrednet:lintcheck-link-correction-again, r=Alexendoo

  Show description for bd1224d
  bors

  committed
  bd1224d

  Copy full SHA for bd1224d

• Fix running compile-test under cargo nextest

  Alexendoo

  committed
  af6d49d

  Copy full SHA for af6d49d

• Make `BindInsteadOfMap` a struct

  Show description for 493498b
  Alexendoo

  committed
  493498b

  Copy full SHA for 493498b

• Auto merge of #13143 - Alexendoo:transmute-ptr-to-ptr-suggestions, r=y21

  Show description for e91d82e
  bors

  committed
  e91d82e

  Copy full SHA for e91d82e

• Temporarily remove myself from reviewer rotation

  blyxyas

  committed
  5ea7044

  Copy full SHA for 5ea7044

• Auto merge of #13154 - blyxyas:focus-on-contribs, r=blyxyas

  Show description for 760a278
  bors

  committed
  760a278

  Copy full SHA for 760a278

• Auto merge of #13151 - Alexendoo:nextest, r=Jarcho

  Show description for 615284a
  bors

  committed
  615284a

  Copy full SHA for 615284a

• Replace local variables signifying "done" or "loop break", use ControlFlow #12830

  blyxyas

  committed
  b21a91a

  Copy full SHA for b21a91a

Commits on Jul 24, 2024

• Auto merge of #13153 - Alexendoo:bind-instead-of-map-struct, r=Manishearth

  Show description for 959477e
  bors

  committed
  959477e

  Copy full SHA for 959477e

• Auto merge of #127524 - oli-obk:feed_item_attrs2, r=petrochenkov

  Show description for 6d67468
  bors

  committed
  6d67468

  Copy full SHA for 6d67468

• Auto merge of #12830 - blyxyas:more-controlflow, r=y21,xFredNet

  Show description for 16953ce
  bors

  committed
  16953ce

  Copy full SHA for 16953ce

• Lint casts to `u128` in `cast_lossless`

  Alexendoo

  committed
  6d28e1a

  Copy full SHA for 6d28e1a

• Lintcheck: Review comments <3

  xFrednet

  committed
  bdf3e58

  Copy full SHA for bdf3e58

• Auto merge of #13146 - Alexendoo:cast-lossless-128, r=y21

  Show description for 5e6540f
  bors

  committed
  5e6540f

  Copy full SHA for 5e6540f

Commits on Jul 25, 2024

• Auto merge of #13139 - xFrednet:lintcheck-limit-summery-output, r=Alexendoo

  Show description for be82340
  bors

  committed
  be82340

  Copy full SHA for be82340

• Auto merge of #13125 - xFrednet:changelog-1-80, r=dswij

  Show description for df0cb6c
  bors

  committed
  df0cb6c

  Copy full SHA for df0cb6c

• Merge remote-tracking branch 'upstream/master' into rustup

  flip1995

  committed
  9f53fc3

  Copy full SHA for 9f53fc3

• Bump nightly version -> 2024-07-25

  flip1995

  committed
  09419e4

  Copy full SHA for 09419e4

• Bump Clippy version -> 0.1.82

  flip1995

  committed
  71b0f0f

  Copy full SHA for 71b0f0f

• Auto merge of #13157 - flip1995:rustup, r=flip1995

  Show description for 37f4fbb
  bors

  committed
  37f4fbb

  Copy full SHA for 37f4fbb

• Merge commit '37f4fbb92913586b73a35772efd00eccd1cbbe13' into clippy-subtree-update

  flip1995

  committed
  b270543

  Copy full SHA for b270543

• Update Cargo.lock

  flip1995

  committed
  0949ff9

  Copy full SHA for 0949ff9