const_refs_to_static test and cleanup #126577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri |
RalfJung
reviewed
Jun 17, 2024
RalfJung
reviewed
Jun 17, 2024
RalfJung
reviewed
Jun 17, 2024
|
r=me with comment nits resolved |
|
@bors r=RalfJung |
bors
added
S-waiting-on-bors
|
@bors rollup |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jun 17, 2024
const_refs_to_static test and cleanup r? `@RalfJung` test the existing behaviour of adt_const_params combined with const_refs_to_static. also remove a dead error variant about consts referring to statics
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 17, 2024
…iaskrgr Rollup of 3 pull requests Successful merges: - rust-lang#126568 (mark undetermined if target binding in current ns is not got) - rust-lang#126577 (const_refs_to_static test and cleanup) - rust-lang#126584 (Do not ICE in privacy when type inference fails.) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 17, 2024
Rollup merge of rust-lang#126577 - oli-obk:static_valtrees, r=RalfJung const_refs_to_static test and cleanup r? ``@RalfJung`` test the existing behaviour of adt_const_params combined with const_refs_to_static. also remove a dead error variant about consts referring to statics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @RalfJung
test the existing behaviour of adt_const_params combined with const_refs_to_static.
also remove a dead error variant about consts referring to statics