Skip to content

Miri std tests: don't set BOOTSTRAP_SKIP_TARGET_SANITY unnecessarily #126149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 8, 2024
Merged

Miri std tests: don't set BOOTSTRAP_SKIP_TARGET_SANITY unnecessarily #126149

merged 1 commit into from
Jun 8, 2024

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Jun 8, 2024

Also explain why we disable isolation, while we are at it.

@rustbot
Copy link
Collaborator

rustbot commented Jun 8, 2024

r? @clubby789

rustbot has assigned @clubby789.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jun 8, 2024
@clubby789
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 8, 2024

📌 Commit d5671d0 has been approved by clubby789

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 8, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 8, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 8, 2024
@bors
Auto merge of rust-lang#126167 - matthiaskrgr:rollup-r717w0s, r=matth…
565cadb 
…iaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#126132 (config.example.toml: minor improves)
 - rust-lang#126149 (Miri std tests: don't set BOOTSTRAP_SKIP_TARGET_SANITY unnecessarily)
 - rust-lang#126157 (add missing Scalar::from_i128)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ea26e7b into rust-lang:master Jun 8, 2024
6 checks passed
@rustbot rustbot added this to the 1.81.0 milestone Jun 8, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jun 8, 2024
@rust-timer
Unrolled build for rust-lang#126149
d6643b1 
Rollup merge of rust-lang#126149 - RalfJung:miri-std-tests, r=clubby789

Miri std tests: don't set BOOTSTRAP_SKIP_TARGET_SANITY unnecessarily

Also explain why we disable isolation, while we are at it.
@RalfJung RalfJung deleted the miri-std-tests branch June 8, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@clubby789 clubby789

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.81.0
Development

Successfully merging this pull request may close these issues.
4 participants
@RalfJung @rustbot @clubby789 @bors