Don't overwrite the options.output value from build_session_options #11502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors
added a commit
that referenced
this pull request
Jan 12, 2014
This is unnecessary and also leads to a bug: When the user specifies ``` #[crate_type = "rlib"]; ``` rustpkg still creates a dylib. Also it's good not to duplicate functionality. `build_session_options` handles this just fine.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Sep 25, 2023
fix FP of let_unit_value on async fn args changelog: [`let_unit_value`]: fix the FalsePostive on async fn arguments fix rust-lang#11502
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is unnecessary and also leads to a bug: When the user specifies
rustpkg still creates a dylib.
Also it's good not to duplicate functionality.
build_session_optionshandles this just fine.