-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Make x.py work again in most (all?) cases #111067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @ozkanonur (rustbot has picked a reviewer for you, use r? to override) |
2b13a32
to
ee1446a
Compare
@bors r+ rollup p=20 (fixes x on Windows) |
📌 Commit ee1446af10e4dfaa8718e5fae468452ecfbc8af6 has been approved by It is now in the queue for this repository. |
This comment has been minimized.
This comment has been minimized.
😩 @bors r- |
Wrap all of x.py in `if __name__ == '__main__':` to avoid problems with `multiprocessing` Make the pool sizing better
ee1446a
to
3011949
Compare
@bors r=jyn514 |
☀️ Test successful - checks-actions |
Finished benchmarking commit (dbba594): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 656.548s -> 656.457s (-0.01%) |
Fixes #111046.
Wrap all of x.py in
if __name__ == '__main__':
to avoid problems withmultiprocessing
Make the pool sizing better