stop x fmt formatting untracked directories
#110664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
jyn514
approved these changes
Apr 22, 2023
Comment on lines
147
to
+149
| .filter(|entry| entry.starts_with("??")) | ||
| .filter_map(|entry| { | ||
| let path = | ||
| entry.split(' ').nth(1).expect("every git status entry should list a path"); | ||
| path.ends_with(".rs").then_some(path) | ||
| .map(|entry| { | ||
| entry.split(' ').nth(1).expect("every git status entry should list a path") |
There was a problem hiding this comment.
you can simplify this slightly:
.filter_map(|entry| entry.strip_prefix("?? "))
(and remove .filter above)
|
@bors delegate=Ezrashaw rollup |
|
✌️ @Ezrashaw can now approve this pull request |
jyn514
changed the title
x fmt formatting alt build dirsx fmt formatting untracked directories
|
Personally I think it's looks cleaner as is but that's just me. @bors r+ (ooh the power) |
bors
added
S-waiting-on-bors
|
@bors r- r=jyn514 |
bors
added
S-waiting-on-author
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 22, 2023
…t, r=jyn514 stop `x fmt` formatting untracked directories I don't think there's anything else to do? I've confirmed that you get a "skip untracked path foo/ during rustfmt invocations" for the alternative build directory. r? `@jyn514`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 22, 2023
…t, r=jyn514 stop `x fmt` formatting untracked directories I don't think there's anything else to do? I've confirmed that you get a "skip untracked path foo/ during rustfmt invocations" for the alternative build directory. r? ``@jyn514``
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Apr 22, 2023
…t, r=jyn514 stop `x fmt` formatting untracked directories I don't think there's anything else to do? I've confirmed that you get a "skip untracked path foo/ during rustfmt invocations" for the alternative build directory. r? ```@jyn514```
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 24, 2023
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#110661 (rustdoc: clean up settings.css and settings.js) - rust-lang#110663 (Add note about change in bootstrap defaults) - rust-lang#110664 (stop `x fmt` formatting untracked directories) - rust-lang#110668 (Fix printing native CPU on cross-compiled compiler.) - rust-lang#110689 (Fix grammar in core::hint::unreachable_unchecked() docs) - rust-lang#110700 (Don't infer fn return type to return itself) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think there's anything else to do? I've confirmed that you get a "skip untracked path foo/ during rustfmt invocations" for the alternative build directory.
r? @jyn514