Skip to content

Start using @str instead of @~str in the compiler #5048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
catamorphism opened this issue Feb 20, 2013 · 2 comments
Closed

Start using @str instead of @~str in the compiler #5048

catamorphism opened this issue Feb 20, 2013 · 2 comments
Labels
A-frontend Area: Compiler frontend (errors, parsing and HIR) C-cleanup Category: PRs that clean code up or issues documenting cleanup.

Comments

@catamorphism
Copy link
Contributor

Blocked on #4526
@catamorphism
Copy link
Contributor Author

Not critical for 0.7. De-milestoning.

@huonw huonw mentioned this issue Jun 12, 2013
Merged
huonw added a commit to huonw/rust that referenced this issue Jun 13, 2013
@huonw
Use @str instead of @~str in libsyntax and librustc. Fixes rust-lang#…
096f6f5 
…5048.

This almost removes the StringRef wrapper, since all strings are
Equiv-alent now. Removes a lot of `/* bad */ copy *`'s, and converts
several things to be &'static str (the lint table and the intrinsics
table).

There are many instances of .to_managed(), unfortunately.
bors added a commit that referenced this issue Jun 13, 2013
@bors
auto merge of #7086 : huonw/rust/5048, r=graydon
da510bf 
Fixes #5048.

I'm sure this reduces memory usage, but I can't get cgroups to work properly to actually measure memory. (It doesn't appear to offer much speed improvement, but I'm fairly sure it's not slower.)

This is quite huge, so it'd be nice to get a resolution soon.
@Aatch
Copy link
Contributor

Aatch commented Jun 13, 2013

Closed by #7086

@Aatch Aatch closed this as completed Jun 13, 2013
bors added a commit to rust-lang-ci/rust that referenced this issue May 2, 2020
@bors
Auto merge of rust-lang#5048 - justjavac:patch-1, r=llogiq
d13b678 
update license year to 2020

Happy new year 2020

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-frontend Area: Compiler frontend (errors, parsing and HIR) C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Aatch @catamorphism