-
Notifications
You must be signed in to change notification settings - Fork 13.3k
issue-13560.rs is flaky on 64-bit OSX #19501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I don't have enough time to investigate this thoroughly, so for now let's get the queue moving by ignoring this test. cc rust-lang#19501
It appears that the compiler is producing corrupt metadata somehow. I have modified the test to ignore The compilation of the -3 crate is the one that's failing, and it will deterministically fail depending on the metadata of the -2 crate. I do not currently know where the extra bytes come from, still trying to track that down... |
I don't have enough time to investigate this thoroughly, so for now let's get the queue moving by ignoring this test. cc #19501
One of the causes of #19501 was that the metadata on OSX was getting corrupted. For any one particular invocation of the compiler the metadata file inside of an rlib archive would have extra bytes appended to the end of it. These extra bytes end up confusing rbml and have it run off the end of the array (resulting in the out of bounds detected). This commit prepends the length of metadata to the start of the metadata to ensure that we always slice the precise amount that we want, and it also un-ignores the test from #19502. Closes #19501
fix: Fix a bug in MBE expansion that arose from incorrect fixing of an older bug in MBE
Tracking issue for this failure:
The text was updated successfully, but these errors were encountered: