Skip to content

Tracking issue for ergonomic reference counting #132290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
1 of 11 tasks
traviscross opened this issue Oct 28, 2024 · 2 comments
Open
1 of 11 tasks

Tracking issue for ergonomic reference counting #132290

traviscross opened this issue Oct 28, 2024 · 2 comments
Labels
C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC F-ergonomic_clones `#![feature(ergonomic_clones)]` T-lang Relevant to the language team, which will review and decide on the PR/issue.

Comments

@traviscross
Copy link
Contributor

traviscross commented Oct 28, 2024 •
edited by RalfJung
Loading

This is a tracking issue for ergonomic reference counting, including:

...and other work.

The feature gate for this issue is #![feature(ergonomic_clones)].

About tracking issues

Tracking issues are used to record the overall progress of implementation. They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions. A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature. Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.

Steps

Unresolved Questions

  • Name of UseCloned trait which signals x.use to clone
  • Precise set of UseCloned impls -- in particular any blanket impls we ought to be concerned about?
  • should x.use work on !Clone types? Currently the impl just generates a move

Related

cc @spastorino @jkelleyrtp @rust-lang/lang
@traviscross traviscross added the C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC label Oct 28, 2024
@compiler-errors
Copy link
Member

compiler-errors commented Oct 28, 2024 •
edited by traviscross
Loading

This feature gate name (ed: use, as currently noted in RFC 3680) is waaaaaaaaaaay too vague. It literally has nothing to do with what the feature actually is doing. This should be called like... ergonomic_clones or something lol.

Also, it's literally not syntactical. Feature gates need to have valid identifiers as names.

@traviscross
Copy link
Contributor Author

Sounds good to me.

@rustbot labels +F-ergonomic_clones

@rustbot rustbot added the F-ergonomic_clones `#![feature(ergonomic_clones)]` label Oct 28, 2024
@traviscross traviscross added the T-lang Relevant to the language team, which will review and decide on the PR/issue. label Oct 28, 2024
@spastorino spastorino mentioned this issue Dec 26, 2024
Merged
@dtolnay dtolnay mentioned this issue Dec 26, 2024
Open
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Mar 7, 2025
@matthiaskrgr
Rollup merge of rust-lang#134797 - spastorino:ergonomic-ref-counting-…
ef627fb 
…1, r=nikomatsakis

Ergonomic ref counting

This is an experimental first version of ergonomic ref counting.

This first version implements most of the RFC but doesn't implement any of the optimizations. This was left for following iterations.

RFC: rust-lang/rfcs#3680
Tracking issue: rust-lang#132290
Project goal: rust-lang/rust-project-goals#107

r? `@nikomatsakis`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Mar 7, 2025
@matthiaskrgr
Rollup merge of rust-lang#134797 - spastorino:ergonomic-ref-counting-…
9bdbb35 
…1, r=nikomatsakis

Ergonomic ref counting

This is an experimental first version of ergonomic ref counting.

This first version implements most of the RFC but doesn't implement any of the optimizations. This was left for following iterations.

RFC: rust-lang/rfcs#3680
Tracking issue: rust-lang#132290
Project goal: rust-lang/rust-project-goals#107

r? ``@nikomatsakis``
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Mar 7, 2025
@matthiaskrgr
Rollup merge of rust-lang#134797 - spastorino:ergonomic-ref-counting-…
f5a143f 
…1, r=nikomatsakis

Ergonomic ref counting

This is an experimental first version of ergonomic ref counting.

This first version implements most of the RFC but doesn't implement any of the optimizations. This was left for following iterations.

RFC: rust-lang/rfcs#3680
Tracking issue: rust-lang#132290
Project goal: rust-lang/rust-project-goals#107

r? ```@nikomatsakis```
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Mar 7, 2025
@rust-timer
Unrolled build for rust-lang#134797
5cf6602 
Rollup merge of rust-lang#134797 - spastorino:ergonomic-ref-counting-1, r=nikomatsakis

Ergonomic ref counting

This is an experimental first version of ergonomic ref counting.

This first version implements most of the RFC but doesn't implement any of the optimizations. This was left for following iterations.

RFC: rust-lang/rfcs#3680
Tracking issue: rust-lang#132290
Project goal: rust-lang/rust-project-goals#107

r? ```@nikomatsakis```
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this issue Mar 14, 2025
@matthiaskrgr
Rollup merge of rust-lang#134797 - spastorino:ergonomic-ref-counting-…
d15d3f7 
…1, r=nikomatsakis

Ergonomic ref counting

This is an experimental first version of ergonomic ref counting.

This first version implements most of the RFC but doesn't implement any of the optimizations. This was left for following iterations.

RFC: rust-lang/rfcs#3680
Tracking issue: rust-lang#132290
Project goal: rust-lang/rust-project-goals#107

r? ```@nikomatsakis```
mohe2015 pushed a commit to tucant/rustfmt that referenced this issue Mar 16, 2025
@matthiaskrgr
Rollup merge of #134797 - spastorino:ergonomic-ref-counting-1, r=niko…
f9f0ac2 
…matsakis

Ergonomic ref counting

This is an experimental first version of ergonomic ref counting.

This first version implements most of the RFC but doesn't implement any of the optimizations. This was left for following iterations.

RFC: rust-lang/rfcs#3680
Tracking issue: rust-lang/rust#132290
Project goal: rust-lang/rust-project-goals#107

r? ```@nikomatsakis```
flip1995 pushed a commit to flip1995/rust-clippy that referenced this issue Mar 20, 2025
@matthiaskrgr
Rollup merge of #134797 - spastorino:ergonomic-ref-counting-1, r=niko…
c919de7 
…matsakis

Ergonomic ref counting

This is an experimental first version of ergonomic ref counting.

This first version implements most of the RFC but doesn't implement any of the optimizations. This was left for following iterations.

RFC: rust-lang/rfcs#3680
Tracking issue: rust-lang/rust#132290
Project goal: rust-lang/rust-project-goals#107

r? ```@nikomatsakis```
@RalfJung RalfJung mentioned this issue Mar 31, 2025
Open
@spastorino spastorino mentioned this issue Mar 31, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue Apr 1, 2025
@bors
Auto merge of rust-lang#139088 - spastorino:ergonomic-ref-counting-2,…
c5e50d7 
… r=<try>

Ergonomic ref counting: optimize away clones when possible

This PR build on top of rust-lang#134797. It optimizes codegen of ergonomic ref-counting when the type being `use`d is only known to be copy after monomorphization. We avoid codening a clone and generate bitwise copy instead.

RFC: rust-lang/rfcs#3680
Tracking issue: rust-lang#132290
Project goal: rust-lang/rust-project-goals#107

r? `@nikomatsakis`

This PR could better sit on top of rust-lang#131650 but as it did not land yet I've decided to just do minimal changes. It may be the case that doing what I'm doing regress the performance and we may need to go the full route of rust-lang#131650.
cc `@saethlin` in this regard.
bors added a commit to rust-lang-ci/rust that referenced this issue Apr 7, 2025
@bors
Auto merge of rust-lang#139088 - spastorino:ergonomic-ref-counting-2,…
aa03ab8 
… r=<try>

Ergonomic ref counting: optimize away clones when possible

This PR build on top of rust-lang#134797. It optimizes codegen of ergonomic ref-counting when the type being `use`d is only known to be copy after monomorphization. We avoid codening a clone and generate bitwise copy instead.

RFC: rust-lang/rfcs#3680
Tracking issue: rust-lang#132290
Project goal: rust-lang/rust-project-goals#107

r? `@nikomatsakis`

This PR could better sit on top of rust-lang#131650 but as it did not land yet I've decided to just do minimal changes. It may be the case that doing what I'm doing regress the performance and we may need to go the full route of rust-lang#131650.
cc `@saethlin` in this regard.
bors added a commit to rust-lang-ci/rust that referenced this issue Apr 10, 2025
@bors
Auto merge of rust-lang#139088 - spastorino:ergonomic-ref-counting-2,…
7d7de5b 
… r=nikomatsakis

Ergonomic ref counting: optimize away clones when possible

This PR build on top of rust-lang#134797. It optimizes codegen of ergonomic ref-counting when the type being `use`d is only known to be copy after monomorphization. We avoid codening a clone and generate bitwise copy instead.

RFC: rust-lang/rfcs#3680
Tracking issue: rust-lang#132290
Project goal: rust-lang/rust-project-goals#107

r? `@nikomatsakis`

This PR could better sit on top of rust-lang#131650 but as it did not land yet I've decided to just do minimal changes. It may be the case that doing what I'm doing regress the performance and we may need to go the full route of rust-lang#131650.
cc `@saethlin` in this regard.
github-merge-queue bot pushed a commit to rust-lang/miri that referenced this issue Apr 10, 2025
@bors
Auto merge of #139088 - spastorino:ergonomic-ref-counting-2, r=nikoma…
a9813aa 
…tsakis

Ergonomic ref counting: optimize away clones when possible

This PR build on top of rust-lang/rust#134797. It optimizes codegen of ergonomic ref-counting when the type being `use`d is only known to be copy after monomorphization. We avoid codening a clone and generate bitwise copy instead.

RFC: rust-lang/rfcs#3680
Tracking issue: rust-lang/rust#132290
Project goal: rust-lang/rust-project-goals#107

r? `@nikomatsakis`

This PR could better sit on top of rust-lang/rust#131650 but as it did not land yet I've decided to just do minimal changes. It may be the case that doing what I'm doing regress the performance and we may need to go the full route of rust-lang/rust#131650.
cc `@saethlin` in this regard.
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this issue Apr 14, 2025
@bors
Auto merge of #139088 - spastorino:ergonomic-ref-counting-2, r=nikoma…
5e11c73 
…tsakis

Ergonomic ref counting: optimize away clones when possible

This PR build on top of rust-lang/rust#134797. It optimizes codegen of ergonomic ref-counting when the type being `use`d is only known to be copy after monomorphization. We avoid codening a clone and generate bitwise copy instead.

RFC: rust-lang/rfcs#3680
Tracking issue: rust-lang/rust#132290
Project goal: rust-lang/rust-project-goals#107

r? `@nikomatsakis`

This PR could better sit on top of rust-lang/rust#131650 but as it did not land yet I've decided to just do minimal changes. It may be the case that doing what I'm doing regress the performance and we may need to go the full route of rust-lang/rust#131650.
cc `@saethlin` in this regard.
lnicola pushed a commit to lnicola/rust-analyzer that referenced this issue Apr 28, 2025
@bors
Auto merge of #139088 - spastorino:ergonomic-ref-counting-2, r=nikoma…
d0ca03a 
…tsakis

Ergonomic ref counting: optimize away clones when possible

This PR build on top of rust-lang/rust#134797. It optimizes codegen of ergonomic ref-counting when the type being `use`d is only known to be copy after monomorphization. We avoid codening a clone and generate bitwise copy instead.

RFC: rust-lang/rfcs#3680
Tracking issue: rust-lang/rust#132290
Project goal: rust-lang/rust-project-goals#107

r? `@nikomatsakis`

This PR could better sit on top of rust-lang/rust#131650 but as it did not land yet I've decided to just do minimal changes. It may be the case that doing what I'm doing regress the performance and we may need to go the full route of rust-lang/rust#131650.
cc `@saethlin` in this regard.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC F-ergonomic_clones `#![feature(ergonomic_clones)]` T-lang Relevant to the language team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@traviscross @compiler-errors @rustbot