Skip to content

document reqd. approvals for target changes #834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

document reqd. approvals for target changes #834

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06d0525
document reqd. approvals for target changes
davidtwco Apr 16, 2025
d17ca36
remove extra space
davidtwco Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/compiler/proposals-and-stabilization.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,11 +263,25 @@ circumstance.
in the description
- New targets should be assigned to the compiler team co-leads to ensure that any demands on
the project infrastructure are considered and checked with relevant teams
- Renaming a target or making a breaking change to a tier three target
- **Propose using:** PR
- **Approve using:** r+
- Open an PR with the proposed rename and describe the motivation for the change and obtain a r+
from the reviewer.
- Renaming a target or making a breaking change to a tier two or one target
- **Propose using:** MCP
- **Approve using:** FCP
- Open an MCP describing the motivation for the change and start an FCP to approve, start an FCP.
- If approved, the change should be accompanied by a blog post announcing the change with a
notice period of at least one release before the change applies.
- Demoting/removing a target
- **Propose using:** MCP
- **Approve using:** FCP
- Write an MCP describing why the target should be demoted/removed and once discussion has
concluded, an FCP can be started to approve the demotion/removal.
- If approved and affecting a tier two or one target, the change should be accompanied by a
blog post announcing the change with a notice period of at least one release before the change
applies.
- Changing target baseline (e.g. minimum Darwin or Windows version bump)
- **Propose using:** MCP
- **Approve using:** FCP
Expand Down