Fix as_deref_mut false positives in needless_option_as_deref
#8646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @giraffate (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
☔ The latest upstream changes (presumably #8606) made this pull request unmergeable. Please resolve the merge conflicts. |
Alexendoo
force-pushed
the
option-as-deref-mut
branch
from
4f36767 to
868072f
Compare
giraffate
reviewed
Apr 7, 2022
clippy_lints/src/methods/mod.rs
Outdated
| @@ -2106,6 +2107,30 @@ declare_clippy_lint! { | |||
| "using `.collect::<Vec<String>>().join(\"\")` on an iterator" | |||
| } | |||
|
|
|||
| declare_clippy_lint! { | |||
| /// ### What it does | |||
| /// Checks for no-op uses of Option::{as_deref,as_deref_mut}, | |||
There was a problem hiding this comment.
nits
Suggested change
| /// Checks for no-op uses of Option::{as_deref,as_deref_mut}, | |
| /// Checks for no-op uses of `Option::{as_deref,as_deref_mut}`, |
Also moves the lint to the methods directory
Alexendoo
force-pushed
the
option-as-deref-mut
branch
from
868072f to
182b7c3
Compare
giraffate
approved these changes
Apr 7, 2022
|
@bors r+ It looks good, thanks! |
|
📌 Commit 182b7c3 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
bors
added a commit
that referenced
this pull request
Apr 14, 2022
Check for loops/closures in `local_used_after_expr` Follow up to #8646, catches when a local is used multiple times because it's in a loop or a closure changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also moves it into
methods/Fixes #7846
Fixes #8047
changelog: [
needless_option_as_deref]: No longer lints foras_deref_muton Options that cannot be movedsupersedes #8064