Skip to content

Rustup for rustc-dev #4654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 12, 2019
Merged

Rustup for rustc-dev #4654

merged 2 commits into from
Oct 12, 2019

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Oct 11, 2019

cc rust-lang/rust#64823
Closes #4651
changelog: none

@tesuji

This comment has been minimized.

@tesuji
Copy link
Contributor Author

tesuji commented Oct 12, 2019

Closed and reopened to trigger CI rebuilt.

@tesuji tesuji closed this Oct 12, 2019
@tesuji tesuji reopened this Oct 12, 2019
@tesuji tesuji closed this Oct 12, 2019
@tesuji tesuji reopened this Oct 12, 2019
@phansch
Copy link
Member

phansch commented Oct 12, 2019

@bors r+ thanks!

@bors
Copy link
Contributor

bors commented Oct 12, 2019

📌 Commit 83f0444 has been approved by phansch

@bors
Copy link
Contributor

bors commented Oct 12, 2019

⌛ Testing commit 83f0444 with merge 4d0e897...

bors added a commit that referenced this pull request Oct 12, 2019
Rustup for rustc-dev

cc rust-lang/rust#64823
Closes #4651
changelog: none
@bors
Copy link
Contributor

bors commented Oct 12, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: phansch
Pushing 4d0e897 to master...

@bors bors merged commit 83f0444 into rust-lang:master Oct 12, 2019
@tesuji tesuji deleted the rustc-dev branch October 12, 2019 07:54
@mati865
Copy link
Contributor

mati865 commented Oct 12, 2019

FYI this PR possibly will have to be reverted soon: rust-lang/rust#65335 (comment)
Once upstream issue is fixed, revert would be reverted.

@tesuji
Copy link
Contributor Author

tesuji commented Oct 12, 2019

There is no need to revert. Just removing rustc-dev component is enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can't build with default rustc master setup
4 participants