correctly check exclusive range patterns for overlap #1490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oli-obk
force-pushed
the
excl_range_pat_overlap
branch
from
5d8a648 to
aebdf74
Compare
mcarton
reviewed
Jan 30, 2017
| @@ -246,11 +247,35 @@ fn overlapping() { | |||
| } | |||
|
|
|||
| match 42 { | |||
| 2 => println!("2"), //~NOTE overlaps with this | |||
| 0 ... 2 => println!("0 ... 5"), //~ERROR: some ranges overlap | |||
|
|
||
| match 42 { | ||
| 0 .. 10 => println!("0 ... 10"), | ||
| 10 .. 50 => println!("0 ... 10"), |
| } | ||
|
|
||
| match 42 { | ||
| 0 .. 11 => println!("0 ... 10"), //~ERROR: some ranges overlap |
There was a problem hiding this comment.
it's kind of correct
|
|
||
| match 42 { | ||
| 0 .. 11 => println!("0 ... 10"), //~ERROR: some ranges overlap | ||
| 0 ... 11 => println!("0 ... 10"), //~NOTE overlaps with this |
| (Bound::Included(a), Bound::Included(b)) | | ||
| (Bound::Excluded(a), Bound::Excluded(b)) => a.cmp(&b), | ||
| (Bound::Unbounded, _) | | ||
| (_, Bound::Unbounded) => unimplemented!(), |
There was a problem hiding this comment.
Maybe add a comment that range patterns need to be bounded? I did not know that and had to check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.